mirror of
https://github.com/facebook/rocksdb.git
synced 2024-11-25 22:44:05 +00:00
42d6652ba2
Summary: The files in `port/`, such as `port_posix.h`, are layering over the system libraries, so shouldn't include the DB-specific files like `options.h`. This PR remove this dependency. # How The reason that `port_posix.h` (or `port_win.h`) include `options.h` is to use `CpuPriority`, as there is a method `SetCpuPriority()` in `port_posix.h` that uses `CpuPriority.` - I think `SetCpuPriority()` make sense to exist in `port_posix.h` as it provides has platform-dependent implementation - `CpuPriority` enum is defined in `env.h`, but used in `rocksdb/include` and `port/`. Hence, let us define `CpuPriority` enum in a common file, say `port_defs.h`, such that both directories `rocksdb/include` and `port/` can include. When we remove this dependency, some other files have compile errors because they can't find definitions, so add header files to resolve # Test make all check -j Pull Request resolved: https://github.com/facebook/rocksdb/pull/11214 Reviewed By: pdillinger Differential Revision: D43196910 Pulled By: guowentian fbshipit-source-id: 70deccb72844cfb08fcc994f76c6ef6df5d55ab9
85 lines
2.5 KiB
C++
85 lines
2.5 KiB
C++
// Copyright (c) 2017-present, Facebook, Inc. All rights reserved.
|
|
// This source code is licensed under both the GPLv2 (found in the
|
|
// COPYING file in the root directory) and Apache 2.0 License
|
|
// (found in the LICENSE.Apache file in the root directory).
|
|
|
|
#pragma once
|
|
|
|
#include <cassert>
|
|
#include <cstddef>
|
|
#include <thread>
|
|
#include <utility>
|
|
#include <vector>
|
|
|
|
#include "port/likely.h"
|
|
#include "port/port.h"
|
|
#include "util/random.h"
|
|
|
|
namespace ROCKSDB_NAMESPACE {
|
|
|
|
// An array of core-local values. Ideally the value type, T, is cache aligned to
|
|
// prevent false sharing.
|
|
template <typename T>
|
|
class CoreLocalArray {
|
|
public:
|
|
CoreLocalArray();
|
|
|
|
size_t Size() const;
|
|
// returns pointer to the element corresponding to the core that the thread
|
|
// currently runs on.
|
|
T* Access() const;
|
|
// same as above, but also returns the core index, which the client can cache
|
|
// to reduce how often core ID needs to be retrieved. Only do this if some
|
|
// inaccuracy is tolerable, as the thread may migrate to a different core.
|
|
std::pair<T*, size_t> AccessElementAndIndex() const;
|
|
// returns pointer to element for the specified core index. This can be used,
|
|
// e.g., for aggregation, or if the client caches core index.
|
|
T* AccessAtCore(size_t core_idx) const;
|
|
|
|
private:
|
|
std::unique_ptr<T[]> data_;
|
|
int size_shift_;
|
|
};
|
|
|
|
template <typename T>
|
|
CoreLocalArray<T>::CoreLocalArray() {
|
|
int num_cpus = static_cast<int>(std::thread::hardware_concurrency());
|
|
// find a power of two >= num_cpus and >= 8
|
|
size_shift_ = 3;
|
|
while (1 << size_shift_ < num_cpus) {
|
|
++size_shift_;
|
|
}
|
|
data_.reset(new T[static_cast<size_t>(1) << size_shift_]);
|
|
}
|
|
|
|
template <typename T>
|
|
size_t CoreLocalArray<T>::Size() const {
|
|
return static_cast<size_t>(1) << size_shift_;
|
|
}
|
|
|
|
template <typename T>
|
|
T* CoreLocalArray<T>::Access() const {
|
|
return AccessElementAndIndex().first;
|
|
}
|
|
|
|
template <typename T>
|
|
std::pair<T*, size_t> CoreLocalArray<T>::AccessElementAndIndex() const {
|
|
int cpuid = port::PhysicalCoreID();
|
|
size_t core_idx;
|
|
if (UNLIKELY(cpuid < 0)) {
|
|
// cpu id unavailable, just pick randomly
|
|
core_idx = Random::GetTLSInstance()->Uniform(1 << size_shift_);
|
|
} else {
|
|
core_idx = static_cast<size_t>(cpuid & ((1 << size_shift_) - 1));
|
|
}
|
|
return {AccessAtCore(core_idx), core_idx};
|
|
}
|
|
|
|
template <typename T>
|
|
T* CoreLocalArray<T>::AccessAtCore(size_t core_idx) const {
|
|
assert(core_idx < static_cast<size_t>(1) << size_shift_);
|
|
return &data_[core_idx];
|
|
}
|
|
|
|
} // namespace ROCKSDB_NAMESPACE
|