mirror of
https://github.com/facebook/rocksdb.git
synced 2024-11-30 22:41:48 +00:00
f9d45358ca
Summary: `check_flush_compaction_key_order` option was introduced for the key order checking online validation. It gave users the ability to disable the validation without downgrade in case the validation caused inefficiencies or false positives. Over time this validation has shown to be cheap and correct, so the option to disable it can now be removed. Pull Request resolved: https://github.com/facebook/rocksdb/pull/12311 Reviewed By: cbi42 Differential Revision: D53233379 Pulled By: ajkr fbshipit-source-id: 1384361104021d6e3e580dce2ec123f9f99ce637
30 lines
1.1 KiB
C++
30 lines
1.1 KiB
C++
// Copyright (c) 2011-present, Facebook, Inc. All rights reserved.
|
|
// This source code is licensed under both the GPLv2 (found in the
|
|
// COPYING file in the root directory) and Apache 2.0 License
|
|
// (found in the LICENSE.Apache file in the root directory).
|
|
//
|
|
#include "db/output_validator.h"
|
|
|
|
#include "test_util/sync_point.h"
|
|
#include "util/hash.h"
|
|
|
|
namespace ROCKSDB_NAMESPACE {
|
|
Status OutputValidator::Add(const Slice& key, const Slice& value) {
|
|
if (enable_hash_) {
|
|
// Generate a rolling 64-bit hash of the key and values
|
|
paranoid_hash_ = NPHash64(key.data(), key.size(), paranoid_hash_);
|
|
paranoid_hash_ = NPHash64(value.data(), value.size(), paranoid_hash_);
|
|
}
|
|
if (key.size() < kNumInternalBytes) {
|
|
return Status::Corruption(
|
|
"Compaction tries to write a key without internal bytes.");
|
|
}
|
|
// prev_key_ starts with empty.
|
|
if (!prev_key_.empty() && icmp_.Compare(key, prev_key_) < 0) {
|
|
return Status::Corruption("Compaction sees out-of-order keys.");
|
|
}
|
|
prev_key_.assign(key.data(), key.size());
|
|
return Status::OK();
|
|
}
|
|
} // namespace ROCKSDB_NAMESPACE
|