mirror of
https://github.com/facebook/rocksdb.git
synced 2024-11-25 22:44:05 +00:00
449029f865
Summary: Regexes are considered potentially problematic for use in registering RocksDB extensions, so we are removing ObjectLibrary::Register() and the Regex public API it depended on (now unused). In reference to https://github.com/facebook/rocksdb/issues/9389 Why? * The power of Regexes can make it hard to reason about which extension will match what. (The replacement API isn't perfect, but we are at least "holding the line" on patterns we have seen in practice.) * It is easy to make regexes that don't quite mean what you think they mean, such as forgetting that the `.` in `foo.bar` can match any character or that matching is nondeterministic, as in `a🅱️42` matching `.*:[0-9]+`. * Some regexes and implementations can have disastrously bad performance. This might not be much practical concern for ObjectLibray here, but we don't want to encourage potentially dangerous further use in production code. (Testing code is fine. See TestRegex.) Pull Request resolved: https://github.com/facebook/rocksdb/pull/9439 Test Plan: CI Reviewed By: mrambacher Differential Revision: D33792342 Pulled By: pdillinger fbshipit-source-id: 4f64dcb04764e639162c8977a5fa196f67754cec
109 lines
3.3 KiB
C++
109 lines
3.3 KiB
C++
// Copyright (c) 2011-present, Facebook, Inc. All rights reserved.
|
|
// This source code is licensed under both the GPLv2 (found in the
|
|
// COPYING file in the root directory) and Apache 2.0 License
|
|
// (found in the LICENSE.Apache file in the root directory).
|
|
//
|
|
// Copyright (c) 2011 The LevelDB Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file. See the AUTHORS file for names of contributors.
|
|
|
|
#include "test_util/testharness.h"
|
|
|
|
#include <regex>
|
|
#include <string>
|
|
#include <thread>
|
|
|
|
namespace ROCKSDB_NAMESPACE {
|
|
namespace test {
|
|
|
|
#ifdef OS_WIN
|
|
#include <windows.h>
|
|
|
|
std::string GetPidStr() { return std::to_string(GetCurrentProcessId()); }
|
|
#else
|
|
std::string GetPidStr() { return std::to_string(getpid()); }
|
|
#endif
|
|
|
|
::testing::AssertionResult AssertStatus(const char* s_expr, const Status& s) {
|
|
if (s.ok()) {
|
|
return ::testing::AssertionSuccess();
|
|
} else {
|
|
return ::testing::AssertionFailure() << s_expr << std::endl
|
|
<< s.ToString();
|
|
}
|
|
}
|
|
|
|
std::string TmpDir(Env* env) {
|
|
std::string dir;
|
|
Status s = env->GetTestDirectory(&dir);
|
|
EXPECT_OK(s);
|
|
return dir;
|
|
}
|
|
|
|
std::string PerThreadDBPath(std::string dir, std::string name) {
|
|
size_t tid = std::hash<std::thread::id>()(std::this_thread::get_id());
|
|
return dir + "/" + name + "_" + GetPidStr() + "_" + std::to_string(tid);
|
|
}
|
|
|
|
std::string PerThreadDBPath(std::string name) {
|
|
return PerThreadDBPath(test::TmpDir(), name);
|
|
}
|
|
|
|
std::string PerThreadDBPath(Env* env, std::string name) {
|
|
return PerThreadDBPath(test::TmpDir(env), name);
|
|
}
|
|
|
|
int RandomSeed() {
|
|
const char* env = getenv("TEST_RANDOM_SEED");
|
|
int result = (env != nullptr ? atoi(env) : 301);
|
|
if (result <= 0) {
|
|
result = 301;
|
|
}
|
|
return result;
|
|
}
|
|
|
|
TestRegex::TestRegex(const std::string& pattern)
|
|
: impl_(std::make_shared<Impl>(pattern)), pattern_(pattern) {}
|
|
TestRegex::TestRegex(const char* pattern)
|
|
: impl_(std::make_shared<Impl>(pattern)), pattern_(pattern) {}
|
|
|
|
const std::string& TestRegex::GetPattern() const { return pattern_; }
|
|
|
|
class TestRegex::Impl : public std::regex {
|
|
public:
|
|
using std::regex::basic_regex;
|
|
};
|
|
|
|
bool TestRegex::Matches(const std::string& str) const {
|
|
if (impl_) {
|
|
return std::regex_match(str, *impl_);
|
|
} else {
|
|
// Should not call Matches on unset Regex
|
|
assert(false);
|
|
return false;
|
|
}
|
|
}
|
|
|
|
::testing::AssertionResult AssertMatchesRegex(const char* str_expr,
|
|
const char* pattern_expr,
|
|
const std::string& str,
|
|
const TestRegex& pattern) {
|
|
if (pattern.Matches(str)) {
|
|
return ::testing::AssertionSuccess();
|
|
} else if (TestRegex("\".*\"").Matches(pattern_expr)) {
|
|
// constant regex string
|
|
return ::testing::AssertionFailure()
|
|
<< str << " (" << str_expr << ")" << std::endl
|
|
<< "does not match regex " << pattern.GetPattern();
|
|
} else {
|
|
// runtime regex string
|
|
return ::testing::AssertionFailure()
|
|
<< str << " (" << str_expr << ")" << std::endl
|
|
<< "does not match regex" << std::endl
|
|
<< pattern.GetPattern() << " (" << pattern_expr << ")";
|
|
}
|
|
}
|
|
|
|
} // namespace test
|
|
} // namespace ROCKSDB_NAMESPACE
|