mirror of
https://github.com/facebook/rocksdb.git
synced 2024-11-27 02:44:18 +00:00
0cdaa1a804
Summary: `Writer::WriteBuffer` was always called at the beginning of checkpoint/backup. But that log writer has no internal synchronization, which meant the same buffer could be flushed twice in a race condition case, causing a WAL entry to be duplicated. Then subsequent WAL entries would be at unexpected offsets, causing the 32KB block boundaries to be overlapped and manifesting as a corruption. This PR fixes the behavior to only use `WriteBuffer` (via `FlushWAL`) in checkpoint/backup when manual WAL flush is enabled. In that case, users are responsible for providing synchronization between WAL flushes. We can also consider removing the call entirely. Closes https://github.com/facebook/rocksdb/pull/3603 Differential Revision: D7277447 Pulled By: ajkr fbshipit-source-id: 1b15bd7fd930511222b075418c10de0aaa70a35a |
||
|---|---|---|
| .. | ||
| backupable | ||
| blob_db | ||
| cassandra | ||
| checkpoint | ||
| compaction_filters | ||
| convenience | ||
| date_tiered | ||
| document | ||
| geodb | ||
| leveldb_options | ||
| lua | ||
| memory | ||
| merge_operators | ||
| option_change_migration | ||
| options | ||
| persistent_cache | ||
| redis | ||
| simulator_cache | ||
| spatialdb | ||
| table_properties_collectors | ||
| transactions | ||
| ttl | ||
| write_batch_with_index | ||
| col_buf_decoder.cc | ||
| col_buf_decoder.h | ||
| col_buf_encoder.cc | ||
| col_buf_encoder.h | ||
| column_aware_encoding_exp.cc | ||
| column_aware_encoding_test.cc | ||
| column_aware_encoding_util.cc | ||
| column_aware_encoding_util.h | ||
| debug.cc | ||
| env_librados.cc | ||
| env_librados.md | ||
| env_librados_test.cc | ||
| env_mirror.cc | ||
| env_mirror_test.cc | ||
| env_timed.cc | ||
| env_timed_test.cc | ||
| merge_operators.h | ||
| object_registry_test.cc | ||
| util_merge_operators_test.cc | ||