Peter Dillinger e6c5e0ab9a Have Cache use Status::MemoryLimit (#10262) ... Summary: I noticed it would clean up some things to have Cache::Insert() return our MemoryLimit Status instead of Incomplete for the case in which the capacity limit is reached. I suspect this fixes some existing but unknown bugs where this Incomplete could be confused with other uses of Incomplete, especially no_io cases. This is the most suspicious case I noticed, but was not able to reproduce a bug, in part because the existing code is not covered by unit tests (FIXME added): 57adbf0e91/table/get_context.cc (L397) I audited all the existing uses of IsIncomplete and updated those that seemed relevant. HISTORY updated with a clear warning to users of strict_capacity_limit=true to update uses of `IsIncomplete()` Pull Request resolved: https://github.com/facebook/rocksdb/pull/10262 Test Plan: updated unit tests Reviewed By: hx235 Differential Revision: D37473155 Pulled By: pdillinger fbshipit-source-id: 4bd9d9353ccddfe286b03ebd0652df8ce20f99cb		2022-07-06 14:41:46 -07:00
..
cache_simulator.cc	Make TraceRecord and Replayer public (#8611)	2021-08-11 19:32:46 -07:00
cache_simulator.h	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	2020-02-20 12:09:57 -08:00
cache_simulator_test.cc	Make TraceRecord and Replayer public (#8611)	2021-08-11 19:32:46 -07:00
sim_cache.cc	Update Cache::Release param from force_erase to erase_if_last_ref (#9728)	2022-03-22 10:22:18 -07:00
sim_cache_test.cc	Have Cache use Status::MemoryLimit (#10262)	2022-07-06 14:41:46 -07:00