mirror of
https://github.com/facebook/rocksdb.git
synced 2024-11-26 07:30:54 +00:00
efd035164b
Summary: Especially after updating to C++17, I don't see a compelling case for *requiring* any folly components in RocksDB. I was able to purge the existing hard dependencies, and it can be quite difficult to strip out non-trivial components from folly for use in RocksDB. (The prospect of doing that on F14 has changed my mind on the best approach here.) But this change creates an optional integration where we can plug in components from folly at compile time, starting here with F14FastMap to replace std::unordered_map when possible (probably no public APIs for example). I have replaced the biggest CPU users of std::unordered_map with compile-time pluggable UnorderedMap which will use F14FastMap when USE_FOLLY is set. USE_FOLLY is always set in the Meta-internal buck build, and a simulation of that is in the Makefile for public CI testing. A full folly build is not needed, but checking out the full folly repo is much simpler for getting the dependency, and anything else we might want to optionally integrate in the future. Some picky details: * I don't think the distributed mutex stuff is actually used, so it was easy to remove. * I implemented an alternative to `folly::constexpr_log2` (which is much easier in C++17 than C++11) so that I could pull out the hard dependencies on `ConstexprMath.h` * I had to add noexcept move constructors/operators to some types to make F14's complainUnlessNothrowMoveAndDestroy check happy, and I added a macro to make that easier in some common cases. * Updated Meta-internal buck build to use folly F14Map (always) No updates to HISTORY.md nor INSTALL.md as this is not (yet?) considered a production integration for open source users. Pull Request resolved: https://github.com/facebook/rocksdb/pull/9546 Test Plan: CircleCI tests updated so that a couple of them use folly. Most internal unit & stress/crash tests updated to use Meta-internal latest folly. (Note: they should probably use buck but they currently use Makefile.) Example performance improvement: when filter partitions are pinned in cache, they are tracked by PartitionedFilterBlockReader::filter_map_ and we can build a test that exercises that heavily. Build DB with ``` TEST_TMPDIR=/dev/shm/rocksdb ./db_bench -benchmarks=fillrandom -num=10000000 -disable_wal=1 -write_buffer_size=30000000 -bloom_bits=16 -compaction_style=2 -fifo_compaction_max_table_files_size_mb=10000 -fifo_compaction_allow_compaction=0 -partition_index_and_filters ``` and test with (simultaneous runs with & without folly, ~20 times each to see convergence) ``` TEST_TMPDIR=/dev/shm/rocksdb ./db_bench_folly -readonly -use_existing_db -benchmarks=readrandom -num=10000000 -bloom_bits=16 -compaction_style=2 -fifo_compaction_max_table_files_size_mb=10000 -fifo_compaction_allow_compaction=0 -partition_index_and_filters -duration=40 -pin_l0_filter_and_index_blocks_in_cache ``` Average ops/s no folly: 26229.2 Average ops/s with folly: 26853.3 (+2.4%) Reviewed By: ajkr Differential Revision: D34181736 Pulled By: pdillinger fbshipit-source-id: ffa6ad5104c2880321d8a1aa7187e00ab0d02e94
99 lines
1 KiB
Plaintext
99 lines
1 KiB
Plaintext
make_config.mk
|
|
rocksdb.pc
|
|
|
|
*.a
|
|
*.arc
|
|
*.d
|
|
*.dylib*
|
|
*.gcda
|
|
*.gcno
|
|
*.o
|
|
*.o.tmp
|
|
*.so
|
|
*.so.*
|
|
*_test
|
|
*_bench
|
|
*_stress
|
|
*.out
|
|
*.class
|
|
*.jar
|
|
*.*jnilib*
|
|
*.d-e
|
|
*.o-*
|
|
*.swp
|
|
*~
|
|
*.vcxproj
|
|
*.vcxproj.filters
|
|
*.sln
|
|
*.cmake
|
|
.watchmanconfig
|
|
CMakeCache.txt
|
|
CMakeFiles/
|
|
build/
|
|
|
|
ldb
|
|
manifest_dump
|
|
sst_dump
|
|
blob_dump
|
|
block_cache_trace_analyzer
|
|
db_with_timestamp_basic_test
|
|
tools/block_cache_analyzer/*.pyc
|
|
column_aware_encoding_exp
|
|
util/build_version.cc
|
|
build_tools/VALGRIND_LOGS/
|
|
coverage/COVERAGE_REPORT
|
|
.gdbhistory
|
|
.gdb_history
|
|
package/
|
|
unity.a
|
|
tags
|
|
etags
|
|
rocksdb_dump
|
|
rocksdb_undump
|
|
db_test2
|
|
trace_analyzer
|
|
trace_analyzer_test
|
|
block_cache_trace_analyzer
|
|
io_tracer_parser
|
|
.DS_Store
|
|
.vs
|
|
.vscode
|
|
|
|
java/out
|
|
java/target
|
|
java/test-libs
|
|
java/*.log
|
|
java/include/org_rocksdb_*.h
|
|
|
|
.idea/
|
|
*.iml
|
|
|
|
rocksdb.cc
|
|
rocksdb.h
|
|
unity.cc
|
|
java/crossbuild/.vagrant
|
|
.vagrant/
|
|
java/**/*.asc
|
|
java/javadoc
|
|
|
|
scan_build_report/
|
|
t
|
|
LOG
|
|
|
|
db_logs/
|
|
tp2/
|
|
fbcode/
|
|
fbcode
|
|
buckifier/*.pyc
|
|
buckifier/__pycache__
|
|
|
|
compile_commands.json
|
|
clang-format-diff.py
|
|
.py3/
|
|
|
|
fuzz/proto/gen/
|
|
fuzz/crash-*
|
|
|
|
cmake-build-*
|
|
third-party/folly/
|