dolysis/rocksdb
3
0
Fork 0
mirror of https://github.com/facebook/rocksdb.git synced 2024-11-27 11:43:49 +00:00
Code Issues Packages Projects Releases Wiki Activity
rocksdb/options
History
Maysam Yabandeh c57050b770 Use the default copy constructor in Options 
Summary:
Our current implementation of (semi-)copy constructor of DBOptions and ColumnFamilyOptions seems to intend value by value copy, which is what the default copy constructor does anyway. Moreover not using the default constructor has the risk of forgetting to add newly added options.

As an example, allow_2pc seems to be forgotten in the copy constructor which was causing one of the unit tests not seeing its effect.
Closes https://github.com/facebook/rocksdb/pull/2888

Differential Revision: D5846368

Pulled By: maysamyabandeh

fbshipit-source-id: 1ee92a2aeae93886754b7bc039c3411ea2458683
2017-09-15 17:15:10 -07:00
..
cf_options.cc Change RocksDB License 2017-07-15 16:11:23 -07:00
cf_options.h fix some misspellings 2017-08-16 21:57:20 -07:00
db_options.cc Include statistics pointer in ImmutableDBOptions::Dump 2017-08-31 16:27:04 -07:00
db_options.h Change RocksDB License 2017-07-15 16:11:23 -07:00
options.cc Use the default copy constructor in Options 2017-09-15 17:15:10 -07:00
options_helper.cc Replace dynamic_cast<> 2017-07-28 16:27:16 -07:00
options_helper.h regression test for missing init options 2017-09-13 11:56:35 -07:00
options_parser.cc Replace dynamic_cast<> 2017-07-28 16:27:16 -07:00
options_parser.h Replace dynamic_cast<> 2017-07-28 16:27:16 -07:00
options_sanity_check.cc Change RocksDB License 2017-07-15 16:11:23 -07:00
options_sanity_check.h Change RocksDB License 2017-07-15 16:11:23 -07:00
options_settable_test.cc regression test for missing init options 2017-09-13 11:56:35 -07:00
options_test.cc Fix memory leak in OptionsTest::OptionsComposeDecompose 2017-09-15 11:37:37 -07:00