mirror of https://github.com/facebook/rocksdb.git
493a4e28d9
Summary: At least under MacOS, some things were excluded from the build (like Snappy) because the compilation flags were not passed in correctly. This PR does a few things: - Passes the EXTRA_CXX/LDFLAGS into build_detect_platform. This means that if some tool (like TBB for example) is not installed in a standard place, it could still be detected by build_detect_platform. In this case, the developer would invoke: "EXTRA_CXXFLAGS=<path to TBB include> EXTRA_LDFLAGS=<path to TBB library> make", and the build script would find the tools in the extra location. - Changes the compilation tests to use PLATFORM_CXXFLAGS. This change causes the EXTRA_FLAGS passed in to the script to be included in the compilation check. Additionally, flags set by the script itself (like --std=c++11) will be used during the checks. Validated that the make_platform.mk file generated on Linux does not change with this change. On my MacOS machine, the SNAPPY libraries are now available (they were not before as they required --std=c++11 to build). I also verified that I can build against TBB installed on my Mac by passing in the EXTRA CXX and LD FLAGS to the location in which TBB is installed. Pull Request resolved: https://github.com/facebook/rocksdb/pull/8111 Reviewed By: jay-zhuang Differential Revision: D27353516 Pulled By: mrambacher fbshipit-source-id: b6b378c96dbf678bab1479556dcbcb49c47e807d |
||
|---|---|---|
| .. | ||
| amalgamate.py | ||
| build_detect_platform | ||
| dependencies.sh | ||
| dependencies_4.8.1.sh | ||
| dependencies_platform007.sh | ||
| dependencies_platform009.sh | ||
| dockerbuild.sh | ||
| error_filter.py | ||
| fb_compile_mongo.sh | ||
| fbcode_config.sh | ||
| fbcode_config4.8.1.sh | ||
| fbcode_config_platform007.sh | ||
| fbcode_config_platform009.sh | ||
| format-diff.sh | ||
| gnu_parallel | ||
| make_package.sh | ||
| precommit_checker.py | ||
| regression_build_test.sh | ||
| rocksdb-lego-determinator | ||
| run_ci_db_test.ps1 | ||
| setup_centos7.sh | ||
| update_dependencies.sh | ||
| version.sh | ||