mirror of https://github.com/facebook/rocksdb.git
57fcdc264a
Summary: Java's `Status.SubCode` was out of sync with `include/rocksdb/status.h:SubCode`. When running out of disc space this led to an `IllegalArgumentException` because of an invalid status code, rather than just returning the corresponding status code without an exception. I added the missing status codes. By this, we keep the behaviour of throwing an `IllegalArgumentException` in case of newly added status codes that are defined in C but not in Java. We could think of an alternative strategy: add in Java another code "UnknownCode" which acts as a catch-all for all those status codes that are not yet mirrored from C to Java. This approach would never throw an exception but simply return a non-OK status-code. I think the current approach of throwing an Exception in case of a C/Java inconsistency is fine, but if you have some opinion on the alternative strategy, then feel free to comment here. Closes https://github.com/facebook/rocksdb/pull/3050 Differential Revision: D6129682 Pulled By: sagar0 fbshipit-source-id: f2bf44caad650837cffdcb1f93eb793b43580c66 |
||
|---|---|---|
| .. | ||
| backupablejni.cc | ||
| backupenginejni.cc | ||
| cassandra_compactionfilterjni.cc | ||
| cassandra_value_operator.cc | ||
| checkpoint.cc | ||
| clock_cache.cc | ||
| columnfamilyhandle.cc | ||
| compaction_filter.cc | ||
| compaction_filter_factory.cc | ||
| compaction_filter_factory_jnicallback.cc | ||
| compaction_filter_factory_jnicallback.h | ||
| compaction_options_fifo.cc | ||
| compaction_options_universal.cc | ||
| comparator.cc | ||
| comparatorjnicallback.cc | ||
| comparatorjnicallback.h | ||
| compression_options.cc | ||
| env.cc | ||
| env_options.cc | ||
| filter.cc | ||
| ingest_external_file_options.cc | ||
| iterator.cc | ||
| jnicallback.cc | ||
| jnicallback.h | ||
| loggerjnicallback.cc | ||
| loggerjnicallback.h | ||
| lru_cache.cc | ||
| memtablejni.cc | ||
| merge_operator.cc | ||
| options.cc | ||
| options_util.cc | ||
| portal.h | ||
| ratelimiterjni.cc | ||
| remove_emptyvalue_compactionfilterjni.cc | ||
| restorejni.cc | ||
| rocks_callback_object.cc | ||
| rocksdb_exception_test.cc | ||
| rocksjni.cc | ||
| slice.cc | ||
| snapshot.cc | ||
| sst_file_writerjni.cc | ||
| statistics.cc | ||
| statisticsjni.cc | ||
| statisticsjni.h | ||
| table.cc | ||
| transaction_log.cc | ||
| ttl.cc | ||
| write_batch.cc | ||
| write_batch_test.cc | ||
| write_batch_with_index.cc | ||
| writebatchhandlerjnicallback.cc | ||
| writebatchhandlerjnicallback.h | ||