mirror of
https://github.com/facebook/rocksdb.git
synced 2024-11-30 04:41:49 +00:00
bda8d93ba9
Summary: It's always annoying to find a header does not include its own dependencies and only works when included after other includes. This change adds `make check-headers` which validates that each header can be included at the top of a file. Some headers are excluded e.g. because of platform or external dependencies. rocksdb_namespace.h had to be re-worked slightly to enable checking for failure to include it. (ROCKSDB_NAMESPACE is a valid namespace name.) Fixes mostly involve adding and cleaning up #includes, but for FileTraceWriter, a constructor was out-of-lined to make a forward declaration sufficient. This check is not currently run with `make check` but is added to CircleCI build-linux-unity since that one is already relatively fast. Pull Request resolved: https://github.com/facebook/rocksdb/pull/8893 Test Plan: existing tests and resolving issues detected by new check Reviewed By: mrambacher Differential Revision: D30823300 Pulled By: pdillinger fbshipit-source-id: 9fff223944994c83c105e2e6496d24845dc8e572
44 lines
1.5 KiB
C++
44 lines
1.5 KiB
C++
// Copyright (c) 2011-present, Facebook, Inc. All rights reserved.
|
|
// This source code is licensed under both the GPLv2 (found in the
|
|
// COPYING file in the root directory) and Apache 2.0 License
|
|
// (found in the LICENSE.Apache file in the root directory).
|
|
|
|
#pragma once
|
|
|
|
#include <cstddef>
|
|
#include <cstdint>
|
|
#include <string>
|
|
|
|
#include "rocksdb/rocksdb_namespace.h"
|
|
|
|
namespace ROCKSDB_NAMESPACE {
|
|
class ObjectLibrary;
|
|
namespace cassandra {
|
|
struct CassandraOptions {
|
|
static const char* kName() { return "CassandraOptions"; }
|
|
CassandraOptions(int32_t _gc_grace_period_in_seconds, size_t _operands_limit,
|
|
bool _purge_ttl_on_expiration = false)
|
|
: operands_limit(_operands_limit),
|
|
gc_grace_period_in_seconds(_gc_grace_period_in_seconds),
|
|
purge_ttl_on_expiration(_purge_ttl_on_expiration) {}
|
|
// Limit on the number of merge operands.
|
|
size_t operands_limit;
|
|
|
|
// How long (in seconds) tombstoned data remains before it is purged
|
|
int32_t gc_grace_period_in_seconds;
|
|
|
|
// If is set to true, expired data will be directly purged.
|
|
// Otherwise expired data will be converted tombstones first,
|
|
// then be eventually removed after gc grace period. This value should
|
|
// only true if all writes have same ttl setting, otherwise it could bring old
|
|
// data back.
|
|
bool purge_ttl_on_expiration;
|
|
};
|
|
#ifndef ROCKSDB_LITE
|
|
extern "C" {
|
|
int RegisterCassandraObjects(ObjectLibrary& library, const std::string& arg);
|
|
} // extern "C"
|
|
#endif // ROCKSDB_LITE
|
|
} // namespace cassandra
|
|
} // namespace ROCKSDB_NAMESPACE
|