mirror of
https://github.com/facebook/rocksdb.git
synced 2024-11-25 22:44:05 +00:00
62247ffa3b
Summary: When using latest clang (3.6 or 3.7/trunck) rocksdb is failing with many errors. Almost all of them are missing override errors. This diff adds missing override keyword. No manual changes. Prerequisites: bear and clang 3.5 build with extra tools ```lang=bash % USE_CLANG=1 bear make all # generate a compilation database http://clang.llvm.org/docs/JSONCompilationDatabase.html % clang-modernize -p . -include . -add-override % make format ``` Test Plan: Make sure all tests are passing. ```lang=bash % #Use default fb code clang. % make check ``` Verify less error and no missing override errors. ```lang=bash % # Have trunk clang present in path. % ROCKSDB_NO_FBCODE=1 CC=clang CXX=clang++ make ``` Reviewers: igor, kradhakrishnan, rven, meyering, sdong Reviewed By: sdong Subscribers: dhruba, leveldb Differential Revision: https://reviews.facebook.net/D34077
108 lines
3 KiB
C++
108 lines
3 KiB
C++
// Copyright (c) 2013, Facebook, Inc. All rights reserved.
|
|
// This source code is licensed under the BSD-style license found in the
|
|
// LICENSE file in the root directory of this source tree. An additional grant
|
|
// of patent rights can be found in the PATENTS file in the same directory.
|
|
//
|
|
// Copyright (c) 2012 The LevelDB Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file. See the AUTHORS file for names of contributors.
|
|
|
|
#include "rocksdb/slice_transform.h"
|
|
#include "rocksdb/slice.h"
|
|
#include "util/string_util.h"
|
|
|
|
namespace rocksdb {
|
|
|
|
namespace {
|
|
|
|
class FixedPrefixTransform : public SliceTransform {
|
|
private:
|
|
size_t prefix_len_;
|
|
std::string name_;
|
|
|
|
public:
|
|
explicit FixedPrefixTransform(size_t prefix_len)
|
|
: prefix_len_(prefix_len),
|
|
name_("rocksdb.FixedPrefix." + ToString(prefix_len_)) {}
|
|
|
|
virtual const char* Name() const override { return name_.c_str(); }
|
|
|
|
virtual Slice Transform(const Slice& src) const override {
|
|
assert(InDomain(src));
|
|
return Slice(src.data(), prefix_len_);
|
|
}
|
|
|
|
virtual bool InDomain(const Slice& src) const override {
|
|
return (src.size() >= prefix_len_);
|
|
}
|
|
|
|
virtual bool InRange(const Slice& dst) const override {
|
|
return (dst.size() == prefix_len_);
|
|
}
|
|
|
|
virtual bool SameResultWhenAppended(const Slice& prefix) const override {
|
|
return InDomain(prefix);
|
|
}
|
|
};
|
|
|
|
class CappedPrefixTransform : public SliceTransform {
|
|
private:
|
|
size_t cap_len_;
|
|
std::string name_;
|
|
|
|
public:
|
|
explicit CappedPrefixTransform(size_t cap_len)
|
|
: cap_len_(cap_len),
|
|
name_("rocksdb.CappedPrefix." + ToString(cap_len_)) {}
|
|
|
|
virtual const char* Name() const override { return name_.c_str(); }
|
|
|
|
virtual Slice Transform(const Slice& src) const override {
|
|
assert(InDomain(src));
|
|
return Slice(src.data(), std::min(cap_len_, src.size()));
|
|
}
|
|
|
|
virtual bool InDomain(const Slice& src) const override { return true; }
|
|
|
|
virtual bool InRange(const Slice& dst) const override {
|
|
return (dst.size() <= cap_len_);
|
|
}
|
|
|
|
virtual bool SameResultWhenAppended(const Slice& prefix) const override {
|
|
return prefix.size() >= cap_len_;
|
|
}
|
|
};
|
|
|
|
class NoopTransform : public SliceTransform {
|
|
public:
|
|
explicit NoopTransform() { }
|
|
|
|
virtual const char* Name() const override { return "rocksdb.Noop"; }
|
|
|
|
virtual Slice Transform(const Slice& src) const override { return src; }
|
|
|
|
virtual bool InDomain(const Slice& src) const override { return true; }
|
|
|
|
virtual bool InRange(const Slice& dst) const override { return true; }
|
|
|
|
virtual bool SameResultWhenAppended(const Slice& prefix) const override {
|
|
return false;
|
|
}
|
|
};
|
|
|
|
}
|
|
|
|
const SliceTransform* NewFixedPrefixTransform(size_t prefix_len) {
|
|
return new FixedPrefixTransform(prefix_len);
|
|
}
|
|
|
|
const SliceTransform* NewCappedPrefixTransform(size_t cap_len) {
|
|
return new CappedPrefixTransform(cap_len);
|
|
}
|
|
|
|
const SliceTransform* NewNoopTransform() {
|
|
return new NoopTransform;
|
|
}
|
|
|
|
} // namespace rocksdb
|