mirror of
https://github.com/facebook/rocksdb.git
synced 2024-11-30 04:41:49 +00:00
27a124571f
Summary: Several error paths in opening of a plain table would leak memory. PR https://github.com/facebook/rocksdb/issues/5940 opened the leak to one more error path, which happens to have been (mistakenly) exercised by CuckooTableDBTest.AdaptiveTable. That test has been fixed, and the exercising of plain table error cases (more than before) has been added as BadOptions1 and BadOptions2 to PlainTableDBTest. This effectively moved the memory leak to plain_table_db_test. Also here is a cheap fix for the memory leak, without (yet?) changing the signature of ReadTableProperties. This fixes ASAN on unit tests. Pull Request resolved: https://github.com/facebook/rocksdb/pull/5951 Test Plan: make COMPILE_WITH_ASAN=1 check Differential Revision: D18051940 Pulled By: pdillinger fbshipit-source-id: e2952930c09a2b46c4f1ff09818c5090426929de |
||
|---|---|---|
| .. | ||
| plain_table_bloom.cc | ||
| plain_table_bloom.h | ||
| plain_table_builder.cc | ||
| plain_table_builder.h | ||
| plain_table_factory.cc | ||
| plain_table_factory.h | ||
| plain_table_index.cc | ||
| plain_table_index.h | ||
| plain_table_key_coding.cc | ||
| plain_table_key_coding.h | ||
| plain_table_reader.cc | ||
| plain_table_reader.h | ||