Yanqin Jin b283f041f5 Stop tracking syncing live WAL for performance (#10330) ... Summary: With https://github.com/facebook/rocksdb/issues/10087, applications calling `SyncWAL()` or writing with `WriteOptions::sync=true` can suffer from performance regression. This PR reverts to original behavior of tracking the syncing of closed WALs. After we revert back to old behavior, recovery, whether kPointInTime or kAbsoluteConsistency, may fail to detect corruption in synced WALs if the corruption is in the live WAL. Pull Request resolved: https://github.com/facebook/rocksdb/pull/10330 Test Plan: make check Before https://github.com/facebook/rocksdb/issues/10087 ```bash fillsync : 750.269 micros/op 1332 ops/sec 75.027 seconds 100000 operations; 0.1 MB/s (100 ops) fillsync : 776.492 micros/op 1287 ops/sec 77.649 seconds 100000 operations; 0.1 MB/s (100 ops) fillsync [AVG 2 runs] : 1310 (± 44) ops/sec; 0.1 (± 0.0) MB/sec fillsync : 805.625 micros/op 1241 ops/sec 80.563 seconds 100000 operations; 0.1 MB/s (100 ops) fillsync [AVG 3 runs] : 1287 (± 51) ops/sec; 0.1 (± 0.0) MB/sec fillsync [AVG 3 runs] : 1287 (± 51) ops/sec; 0.1 (± 0.0) MB/sec fillsync [MEDIAN 3 runs] : 1287 ops/sec; 0.1 MB/sec ``` Before this PR and after https://github.com/facebook/rocksdb/issues/10087 ```bash fillsync : 1479.601 micros/op 675 ops/sec 147.960 seconds 100000 operations; 0.1 MB/s (100 ops) fillsync : 1626.080 micros/op 614 ops/sec 162.608 seconds 100000 operations; 0.1 MB/s (100 ops) fillsync [AVG 2 runs] : 645 (± 59) ops/sec; 0.1 (± 0.0) MB/sec fillsync : 1588.402 micros/op 629 ops/sec 158.840 seconds 100000 operations; 0.1 MB/s (100 ops) fillsync [AVG 3 runs] : 640 (± 35) ops/sec; 0.1 (± 0.0) MB/sec fillsync [AVG 3 runs] : 640 (± 35) ops/sec; 0.1 (± 0.0) MB/sec fillsync [MEDIAN 3 runs] : 629 ops/sec; 0.1 MB/sec ``` After this PR ```bash fillsync : 749.621 micros/op 1334 ops/sec 74.962 seconds 100000 operations; 0.1 MB/s (100 ops) fillsync : 865.577 micros/op 1155 ops/sec 86.558 seconds 100000 operations; 0.1 MB/s (100 ops) fillsync [AVG 2 runs] : 1244 (± 175) ops/sec; 0.1 (± 0.0) MB/sec fillsync : 845.837 micros/op 1182 ops/sec 84.584 seconds 100000 operations; 0.1 MB/s (100 ops) fillsync [AVG 3 runs] : 1223 (± 109) ops/sec; 0.1 (± 0.0) MB/sec fillsync [AVG 3 runs] : 1223 (± 109) ops/sec; 0.1 (± 0.0) MB/sec fillsync [MEDIAN 3 runs] : 1182 ops/sec; 0.1 MB/sec ``` Reviewed By: ajkr Differential Revision: D37725212 Pulled By: riversand963 fbshipit-source-id: 8fa7d13b3c7662be5d56351c42caf3266af937ae		2022-07-12 17:16:57 -07:00
..
compacted_db_impl.cc	Return "invalid argument" when read timestamp is too old (#10109)	2022-06-06 14:36:22 -07:00
compacted_db_impl.h	Add API for writing wide-column entities (#10242)	2022-06-25 15:30:47 -07:00
db_impl.cc	Stop tracking syncing live WAL for performance (#10330)	2022-07-12 17:16:57 -07:00
db_impl.h	Remove unused variables (#10327)	2022-07-11 13:55:23 -07:00
db_impl_compaction_flush.cc	Dynamically changeable MemPurge option (#10011)	2022-06-23 09:42:18 -07:00
db_impl_debug.cc
db_impl_experimental.cc	Track SST unique id in MANIFEST and verify (#9990)	2022-05-19 11:04:21 -07:00
db_impl_files.cc	Fix race condition between file purge and backup/checkpoint (#10187)	2022-06-23 18:32:25 -07:00
db_impl_open.cc	Handoff checksum during WAL replay (#10212)	2022-07-05 15:44:35 -07:00
db_impl_readonly.cc	Return "invalid argument" when read timestamp is too old (#10109)	2022-06-06 14:36:22 -07:00
db_impl_readonly.h	Add API for writing wide-column entities (#10242)	2022-06-25 15:30:47 -07:00
db_impl_secondary.cc	Update code comment and logging for secondary instance (#10260)	2022-07-05 10:09:44 -07:00
db_impl_secondary.h	Update code comment and logging for secondary instance (#10260)	2022-07-05 10:09:44 -07:00
db_impl_write.cc	Add API for writing wide-column entities (#10242)	2022-06-25 15:30:47 -07:00