Changyu Bi b0e190604b Update VersionSet last seqno after LogAndApply (#10051) ... Summary: This PR fixes the issue of unstable snapshot during external SST file ingestion. Credit ajkr for the following walk through: consider these relevant steps for of IngestExternalFile(): (1) increase seqno while holding mutex -- 677d2b4a8f/db/db_impl/db_impl.cc (L4768) (2) LogAndApply() -- 677d2b4a8f/db/db_impl/db_impl.cc (L4797-L4798) (a) write to MANIFEST with mutex released a96a4a2f7b/db/version_set.cc (L4407) (b) apply to in-memory state with mutex held A snapshot taken during (2a) will be unstable. In particular, queries against that snapshot will not include data from the ingested file before (2b), and will include data from the ingested file after (2b). Pull Request resolved: https://github.com/facebook/rocksdb/pull/10051 Test Plan: Added a new unit test: `ExternalSSTFileBasicTest.WriteAfterReopenStableSnapshotWhileLoggingToManifest`. ``` make external_sst_file_basic_test ./external_sst_file_basic_test ``` Reviewed By: ajkr Differential Revision: D36654033 Pulled By: cbi42 fbshipit-source-id: bf720cca313e0cf211585960f3aff04853a31b96		2022-05-25 10:05:17 -07:00
..
compacted_db_impl.cc
compacted_db_impl.h
db_impl.cc
db_impl.h
db_impl_compaction_flush.cc
db_impl_debug.cc
db_impl_experimental.cc
db_impl_files.cc
db_impl_open.cc
db_impl_readonly.cc
db_impl_readonly.h
db_impl_secondary.cc
db_impl_secondary.h
db_impl_write.cc