mirror of
https://github.com/facebook/rocksdb.git
synced 2024-11-25 22:44:05 +00:00
0c56fc4d66
Summary: RocksDB Makefile was assuming existence of 'python' command, which is not present in CentOS 8. We avoid using 'python' if 'python3' is available. Also added fancy logic to format-diff.sh to make clang-format-diff.py for Python2 work even with Python3 only (as some CentOS 8 FB machines come equipped) Also, now use just 'python3' for PYTHON if not found so that an informative "command not found" error will result rather than something weird. Pull Request resolved: https://github.com/facebook/rocksdb/pull/6883 Test Plan: manually tried some variants, 'make check' on a fresh CentOS 8 machine without 'python' executable or Python2 but with clang-format-diff.py for Python2. Reviewed By: gg814 Differential Revision: D21767029 Pulled By: pdillinger fbshipit-source-id: 54761b376b140a3922407bdc462f3572f461d0e9
33 lines
776 B
Bash
Executable file
33 lines
776 B
Bash
Executable file
#!/usr/bin/env bash
|
|
# Copyright (c) Facebook, Inc. and its affiliates. All Rights Reserved.
|
|
# If clang_format_diff.py command is not specfied, we assume we are able to
|
|
# access directly without any path.
|
|
|
|
TGT_DIFF=`git diff TARGETS | head -n 1`
|
|
|
|
if [ ! -z "$TGT_DIFF" ]
|
|
then
|
|
echo "TARGETS file has uncommitted changes. Skip this check."
|
|
exit 0
|
|
fi
|
|
|
|
echo Backup original TARGETS file.
|
|
|
|
cp TARGETS TARGETS.bkp
|
|
|
|
${PYTHON:-python3} buckifier/buckify_rocksdb.py
|
|
|
|
TGT_DIFF=`git diff TARGETS | head -n 1`
|
|
|
|
if [ -z "$TGT_DIFF" ]
|
|
then
|
|
mv TARGETS.bkp TARGETS
|
|
exit 0
|
|
else
|
|
echo "Please run '${PYTHON:-python3} buckifier/buckify_rocksdb.py' to update TARGETS file."
|
|
echo "Do not manually update TARGETS file."
|
|
${PYTHON:-python3} --version
|
|
mv TARGETS.bkp TARGETS
|
|
exit 1
|
|
fi
|