mirror of
https://github.com/facebook/rocksdb.git
synced 2024-11-30 04:41:49 +00:00
abd6751aba
Summary: **Context/Summary:** https://github.com/facebook/rocksdb/pull/12542 introduced a bug where wrong padded bytes used to generate file checksum if flush happens during padding. This PR fixed it along with an existing same bug for `perform_data_verification_=true`. Pull Request resolved: https://github.com/facebook/rocksdb/pull/12598 Test Plan: - New UT that failed before this fix (`db->VerifyFileChecksums: ...Corruption: ...file checksum mismatch`) and passes after - Benchmark ``` TEST_TMPDIR=/dev/shm ./db_bench --benchmarks=fillseq[-X300] --num=100000 --block_align=1 --compression_type=none ``` Pre-PR: fillseq [AVG 300 runs] : 421334 (± 4126) ops/sec; 46.6 (± 0.5) MB/sec Post-PR: (no regression observed but a slight improvement) fillseq [AVG 300 runs] : 425768 (± 4309) ops/sec; 47.1 (± 0.5) MB/sec Reviewed By: ajkr, anand1976 Differential Revision: D56725688 Pulled By: hx235 fbshipit-source-id: c1a700a95def8c65c0a21e44f8c1966164925ad5 |
||
|---|---|---|
| .. | ||
| .gitkeep | ||
| block_align_checksum_mismatch.md | ||
| consistent_view_for_new_iterators_api.md | ||
| del_range_and_memtable_insert_with_hint_prefix_extractor.md | ||
| disable_manual_compaction_hang.md | ||
| max_successive_merges_regression.md | ||
| multiget_partial_error_blob_dereference.md | ||
| pad_bug.md | ||
| pinnable_wide_columns_move.md | ||
| recycle_logs_toggle_bug.md | ||