mirror of
https://github.com/facebook/rocksdb.git
synced 2024-11-25 22:44:05 +00:00
0d1e0722ef
Summary: The patch fixes a couple of issues related to in-place updates: 1) the value type was not passed from `MemTableInserter::PutCFImpl` to `MemTable::Update` and 2) `MemTable::UpdateCallback` was called for any value type (with the callee's logic assuming `kTypeValue`) even though the callback mechanism is only safe for plain values. Pull Request resolved: https://github.com/facebook/rocksdb/pull/10254 Test Plan: `make check` Reviewed By: riversand963 Differential Revision: D37463644 Pulled By: ltamasi fbshipit-source-id: 33802477dac0691681f416ae84c4d9742c6fe41a
263 lines
8.3 KiB
C++
263 lines
8.3 KiB
C++
// Copyright (c) 2011-present, Facebook, Inc. All rights reserved.
|
|
// This source code is licensed under both the GPLv2 (found in the
|
|
// COPYING file in the root directory) and Apache 2.0 License
|
|
// (found in the LICENSE.Apache file in the root directory).
|
|
//
|
|
// Copyright (c) 2011 The LevelDB Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file. See the AUTHORS file for names of contributors.
|
|
#include "db/db_test_util.h"
|
|
#include "port/stack_trace.h"
|
|
|
|
namespace ROCKSDB_NAMESPACE {
|
|
|
|
class DBTestInPlaceUpdate : public DBTestBase {
|
|
public:
|
|
DBTestInPlaceUpdate()
|
|
: DBTestBase("db_inplace_update_test", /*env_do_fsync=*/true) {}
|
|
};
|
|
|
|
TEST_F(DBTestInPlaceUpdate, InPlaceUpdate) {
|
|
do {
|
|
Options options = CurrentOptions();
|
|
options.create_if_missing = true;
|
|
options.inplace_update_support = true;
|
|
options.env = env_;
|
|
options.write_buffer_size = 100000;
|
|
options.allow_concurrent_memtable_write = false;
|
|
Reopen(options);
|
|
CreateAndReopenWithCF({"pikachu"}, options);
|
|
|
|
// Update key with values of smaller size
|
|
int numValues = 10;
|
|
for (int i = numValues; i > 0; i--) {
|
|
std::string value = DummyString(i, 'a');
|
|
ASSERT_OK(Put(1, "key", value));
|
|
ASSERT_EQ(value, Get(1, "key"));
|
|
}
|
|
|
|
// Only 1 instance for that key.
|
|
validateNumberOfEntries(1, 1);
|
|
} while (ChangeCompactOptions());
|
|
}
|
|
|
|
TEST_F(DBTestInPlaceUpdate, InPlaceUpdateLargeNewValue) {
|
|
do {
|
|
Options options = CurrentOptions();
|
|
options.create_if_missing = true;
|
|
options.inplace_update_support = true;
|
|
options.env = env_;
|
|
options.write_buffer_size = 100000;
|
|
options.allow_concurrent_memtable_write = false;
|
|
Reopen(options);
|
|
CreateAndReopenWithCF({"pikachu"}, options);
|
|
|
|
// Update key with values of larger size
|
|
int numValues = 10;
|
|
for (int i = 0; i < numValues; i++) {
|
|
std::string value = DummyString(i, 'a');
|
|
ASSERT_OK(Put(1, "key", value));
|
|
ASSERT_EQ(value, Get(1, "key"));
|
|
}
|
|
|
|
// All 10 updates exist in the internal iterator
|
|
validateNumberOfEntries(numValues, 1);
|
|
} while (ChangeCompactOptions());
|
|
}
|
|
|
|
TEST_F(DBTestInPlaceUpdate, InPlaceUpdateEntitySmallerNewValue) {
|
|
do {
|
|
Options options = CurrentOptions();
|
|
options.create_if_missing = true;
|
|
options.inplace_update_support = true;
|
|
options.env = env_;
|
|
options.allow_concurrent_memtable_write = false;
|
|
|
|
Reopen(options);
|
|
CreateAndReopenWithCF({"pikachu"}, options);
|
|
|
|
// Update key with values of smaller size
|
|
constexpr int num_values = 10;
|
|
for (int i = num_values; i > 0; --i) {
|
|
constexpr char key[] = "key";
|
|
const std::string value = DummyString(i, 'a');
|
|
WideColumns wide_columns{{"attr", value}};
|
|
|
|
ASSERT_OK(db_->PutEntity(WriteOptions(), handles_[1], key, wide_columns));
|
|
// TODO: use Get to check entity once it's supported
|
|
}
|
|
|
|
// Only 1 instance for that key.
|
|
validateNumberOfEntries(1, 1);
|
|
} while (ChangeCompactOptions());
|
|
}
|
|
|
|
TEST_F(DBTestInPlaceUpdate, InPlaceUpdateEntityLargerNewValue) {
|
|
do {
|
|
Options options = CurrentOptions();
|
|
options.create_if_missing = true;
|
|
options.inplace_update_support = true;
|
|
options.env = env_;
|
|
options.allow_concurrent_memtable_write = false;
|
|
|
|
Reopen(options);
|
|
CreateAndReopenWithCF({"pikachu"}, options);
|
|
|
|
// Update key with values of larger size
|
|
constexpr int num_values = 10;
|
|
for (int i = 0; i < num_values; ++i) {
|
|
constexpr char key[] = "key";
|
|
const std::string value = DummyString(i, 'a');
|
|
WideColumns wide_columns{{"attr", value}};
|
|
|
|
ASSERT_OK(db_->PutEntity(WriteOptions(), handles_[1], key, wide_columns));
|
|
// TODO: use Get to check entity once it's supported
|
|
}
|
|
|
|
// All 10 updates exist in the internal iterator
|
|
validateNumberOfEntries(num_values, 1);
|
|
} while (ChangeCompactOptions());
|
|
}
|
|
|
|
TEST_F(DBTestInPlaceUpdate, InPlaceUpdateCallbackSmallerSize) {
|
|
do {
|
|
Options options = CurrentOptions();
|
|
options.create_if_missing = true;
|
|
options.inplace_update_support = true;
|
|
|
|
options.env = env_;
|
|
options.write_buffer_size = 100000;
|
|
options.inplace_callback =
|
|
ROCKSDB_NAMESPACE::DBTestInPlaceUpdate::updateInPlaceSmallerSize;
|
|
options.allow_concurrent_memtable_write = false;
|
|
Reopen(options);
|
|
CreateAndReopenWithCF({"pikachu"}, options);
|
|
|
|
// Update key with values of smaller size
|
|
int numValues = 10;
|
|
ASSERT_OK(Put(1, "key", DummyString(numValues, 'a')));
|
|
ASSERT_EQ(DummyString(numValues, 'c'), Get(1, "key"));
|
|
|
|
for (int i = numValues; i > 0; i--) {
|
|
ASSERT_OK(Put(1, "key", DummyString(i, 'a')));
|
|
ASSERT_EQ(DummyString(i - 1, 'b'), Get(1, "key"));
|
|
}
|
|
|
|
// Only 1 instance for that key.
|
|
validateNumberOfEntries(1, 1);
|
|
} while (ChangeCompactOptions());
|
|
}
|
|
|
|
TEST_F(DBTestInPlaceUpdate, InPlaceUpdateCallbackSmallerVarintSize) {
|
|
do {
|
|
Options options = CurrentOptions();
|
|
options.create_if_missing = true;
|
|
options.inplace_update_support = true;
|
|
|
|
options.env = env_;
|
|
options.write_buffer_size = 100000;
|
|
options.inplace_callback =
|
|
ROCKSDB_NAMESPACE::DBTestInPlaceUpdate::updateInPlaceSmallerVarintSize;
|
|
options.allow_concurrent_memtable_write = false;
|
|
Reopen(options);
|
|
CreateAndReopenWithCF({"pikachu"}, options);
|
|
|
|
// Update key with values of smaller varint size
|
|
int numValues = 265;
|
|
ASSERT_OK(Put(1, "key", DummyString(numValues, 'a')));
|
|
ASSERT_EQ(DummyString(numValues, 'c'), Get(1, "key"));
|
|
|
|
for (int i = numValues; i > 0; i--) {
|
|
ASSERT_OK(Put(1, "key", DummyString(i, 'a')));
|
|
ASSERT_EQ(DummyString(1, 'b'), Get(1, "key"));
|
|
}
|
|
|
|
// Only 1 instance for that key.
|
|
validateNumberOfEntries(1, 1);
|
|
} while (ChangeCompactOptions());
|
|
}
|
|
|
|
TEST_F(DBTestInPlaceUpdate, InPlaceUpdateCallbackLargeNewValue) {
|
|
do {
|
|
Options options = CurrentOptions();
|
|
options.create_if_missing = true;
|
|
options.inplace_update_support = true;
|
|
|
|
options.env = env_;
|
|
options.write_buffer_size = 100000;
|
|
options.inplace_callback =
|
|
ROCKSDB_NAMESPACE::DBTestInPlaceUpdate::updateInPlaceLargerSize;
|
|
options.allow_concurrent_memtable_write = false;
|
|
Reopen(options);
|
|
CreateAndReopenWithCF({"pikachu"}, options);
|
|
|
|
// Update key with values of larger size
|
|
int numValues = 10;
|
|
for (int i = 0; i < numValues; i++) {
|
|
ASSERT_OK(Put(1, "key", DummyString(i, 'a')));
|
|
ASSERT_EQ(DummyString(i, 'c'), Get(1, "key"));
|
|
}
|
|
|
|
// No inplace updates. All updates are puts with new seq number
|
|
// All 10 updates exist in the internal iterator
|
|
validateNumberOfEntries(numValues, 1);
|
|
} while (ChangeCompactOptions());
|
|
}
|
|
|
|
TEST_F(DBTestInPlaceUpdate, InPlaceUpdateCallbackNoAction) {
|
|
do {
|
|
Options options = CurrentOptions();
|
|
options.create_if_missing = true;
|
|
options.inplace_update_support = true;
|
|
|
|
options.env = env_;
|
|
options.write_buffer_size = 100000;
|
|
options.inplace_callback =
|
|
ROCKSDB_NAMESPACE::DBTestInPlaceUpdate::updateInPlaceNoAction;
|
|
options.allow_concurrent_memtable_write = false;
|
|
Reopen(options);
|
|
CreateAndReopenWithCF({"pikachu"}, options);
|
|
|
|
// Callback function requests no actions from db
|
|
ASSERT_OK(Put(1, "key", DummyString(1, 'a')));
|
|
ASSERT_EQ(Get(1, "key"), "NOT_FOUND");
|
|
} while (ChangeCompactOptions());
|
|
}
|
|
|
|
TEST_F(DBTestInPlaceUpdate, InPlaceUpdateAndSnapshot) {
|
|
do {
|
|
Options options = CurrentOptions();
|
|
options.create_if_missing = true;
|
|
options.inplace_update_support = true;
|
|
options.env = env_;
|
|
options.write_buffer_size = 100000;
|
|
options.allow_concurrent_memtable_write = false;
|
|
Reopen(options);
|
|
CreateAndReopenWithCF({"pikachu"}, options);
|
|
|
|
// Update key with values of smaller size, and
|
|
// run GetSnapshot and ReleaseSnapshot
|
|
int numValues = 2;
|
|
for (int i = numValues; i > 0; i--) {
|
|
const Snapshot* s = db_->GetSnapshot();
|
|
ASSERT_EQ(nullptr, s);
|
|
std::string value = DummyString(i, 'a');
|
|
ASSERT_OK(Put(1, "key", value));
|
|
ASSERT_EQ(value, Get(1, "key"));
|
|
// release s (nullptr)
|
|
db_->ReleaseSnapshot(s);
|
|
}
|
|
|
|
// Only 1 instance for that key.
|
|
validateNumberOfEntries(1, 1);
|
|
} while (ChangeCompactOptions());
|
|
}
|
|
|
|
} // namespace ROCKSDB_NAMESPACE
|
|
|
|
int main(int argc, char** argv) {
|
|
ROCKSDB_NAMESPACE::port::InstallStackTraceHandler();
|
|
::testing::InitGoogleTest(&argc, argv);
|
|
return RUN_ALL_TESTS();
|
|
}
|