mirror of https://github.com/facebook/rocksdb.git
f337533b6f
Summary: **Context/Summary:** It's intuitive for users to assume `TablePropertiesCollector::Finish()` is called only once by RocksDB internal by the word "finish". However, this is currently not true as RocksDB also calls this function in `BlockBased/PlainTableBuilder::GetTableProperties()` to populate user collected properties on demand. This PR avoids that by moving that populating to where we first call `Finish()` (i.e, `NotifyCollectTableCollectorsOnFinish`) Bonus: clarified in the API that `GetReadableProperties()` will be called after `Finish()` and added UT to ensure that. Pull Request resolved: https://github.com/facebook/rocksdb/pull/12053 Test Plan: - Modified test `DBPropertiesTest.GetUserDefinedTableProperties` to ensure `Finish()` only called once. - Existing test particularly `db_properties_test, table_properties_collector_test` verify the functionality `NotifyCollectTableCollectorsOnFinish` and `GetReadableProperties()` are not broken by this change. Reviewed By: ajkr Differential Revision: D51095434 Pulled By: hx235 fbshipit-source-id: 1c6275258f9b99dedad313ee8427119126817973 |
||
|---|---|---|
| .. | ||
| plain_table_bloom.cc | ||
| plain_table_bloom.h | ||
| plain_table_builder.cc | ||
| plain_table_builder.h | ||
| plain_table_factory.cc | ||
| plain_table_factory.h | ||
| plain_table_index.cc | ||
| plain_table_index.h | ||
| plain_table_key_coding.cc | ||
| plain_table_key_coding.h | ||
| plain_table_reader.cc | ||
| plain_table_reader.h | ||