Yanqin Jin a376c22066 Handle rename() failure in non-local FS (#8192) ... Summary: In a distributed environment, a file `rename()` operation can succeed on server (remote) side, but the client can somehow return non-ok status to RocksDB. Possible reasons include network partition, connection issue, etc. This happens in `rocksdb::SetCurrentFile()`, which can be called in `LogAndApply() -> ProcessManifestWrites()` if RocksDB tries to switch to a new MANIFEST. We currently always delete the new MANIFEST if an error occurs. This is problematic in distributed world. If the server-side successfully updates the CURRENT file via renaming, then a subsequent `DB::Open()` will try to look for the new MANIFEST and fail. As a fix, we can track the execution result of IO operations on the new MANIFEST. - If IO operations on the new MANIFEST fail, then we know the CURRENT must point to the original MANIFEST. Therefore, it is safe to remove the new MANIFEST. - If IO operations on the new MANIFEST all succeed, but somehow we end up in the clean up code block, then we do not know whether CURRENT points to the new or old MANIFEST. (For local POSIX-compliant FS, it should still point to old MANIFEST, but it does not matter if we keep the new MANIFEST.) Therefore, we keep the new MANIFEST. - Any future `LogAndApply()` will switch to a new MANIFEST and update CURRENT. - If process reopens the db immediately after the failure, then the CURRENT file can point to either the new MANIFEST or the old one, both of which exist. Therefore, recovery can succeed and ignore the other. Pull Request resolved: https://github.com/facebook/rocksdb/pull/8192 Test Plan: make check Reviewed By: zhichao-cao Differential Revision: D27804648 Pulled By: riversand963 fbshipit-source-id: 9c16f2a5ce41bc6aadf085e48449b19ede8423e4		2021-04-19 18:11:13 -07:00
..
benchmark/src/main/java/org/rocksdb/benchmark
crossbuild
jmh
rocksjni	Add sample_for_compression results to table properties (#8139)	2021-03-31 18:21:50 -07:00
samples/src/main/java
src	Handle rename() failure in non-local FS (#8192)	2021-04-19 18:11:13 -07:00
CMakeLists.txt	support getUsage and getPinnedUsage in JavaAPI for Cache (#7925)	2021-03-17 09:30:33 -07:00
HISTORY-JAVA.md
jdb_bench.sh
Makefile	support getUsage and getPinnedUsage in JavaAPI for Cache (#7925)	2021-03-17 09:30:33 -07:00
pom.xml.template
RELEASE.md