dolysis/rocksdb
3
0
Fork 0
mirror of https://github.com/facebook/rocksdb.git synced 2024-11-29 18:33:58 +00:00
Code Issues Packages Projects Releases Wiki Activity
rocksdb/util
History
Igor Canadi a7e80379b0 LogAndApply() should fail if the column family has been dropped 
Summary:
This patch finally fixes the ColumnFamilyTest.ReadDroppedColumnFamily test. The test has been failing very sporadically and it was hard to repro. However, I managed to write a new tests that reproes the failure deterministically.

Here's what happens:
1. We start the flush for the column family
2. We check if the column family was dropped here: a3fc49bfdd/db/flush_job.cc (L149)
3. This check goes through, ends up in InstallMemtableFlushResults() and it goes into LogAndApply()
4. At about this time, we start dropping the column family. Dropping the column family process gets to LogAndApply() at about the same time as LogAndApply() from flush process
5. Drop column family goes through LogAndApply() first, marking the column family as dropped.
6. Flush process gets woken up and gets a chance to write to the MANIFEST. However, this is where it gets stuck: a3fc49bfdd/db/version_set.cc (L1975)
7. We see that the column family was dropped, so there is no need to write to the MANIFEST. We return OK.
8. Flush gets OK back from LogAndApply() and it deletes the memtable, thinking that the data is now safely persisted to sst file.

The fix is pretty simple. Instead of OK, we return ShutdownInProgress. This is not really true, but we have been using this status code to also mean "this operation was canceled because the column family has been dropped".

The fix is only one LOC. All other code is related to tests. I added a new test that reproes the failure. I also moved SleepingBackgroundTask to util/testutil.h (because I needed it in column_family_test for my new test). There's plenty of other places where we reimplement SleepingBackgroundTask, but I'll address that in a separate commit.

Test Plan:
1. new test
2. make check
3. Make sure the ColumnFamilyTest.ReadDroppedColumnFamily doesn't fail on Travis: https://travis-ci.org/facebook/rocksdb/jobs/79952386

Reviewers: yhchiang, anthony, IslamAbdelRahman, kradhakrishnan, rven, sdong

Reviewed By: sdong

Subscribers: dhruba, leveldb

Differential Revision: https://reviews.facebook.net/D46773
2015-09-15 11:28:44 -07:00
..
aligned_buffer.h Address code review comments both GH and internal 2015-09-11 17:36:48 -07:00
allocator.h
arena.cc Arena usage to be calculated using malloc_usable_size() 2015-08-31 09:39:27 -07:00
arena.h
arena_test.cc Relax asserts in arena_test 2015-09-14 11:54:47 -07:00
auto_roll_logger.cc Fix WinEnv::NowMicrosec 2015-07-22 14:36:43 -07:00
auto_roll_logger.h Windows Port from Microsoft 2015-07-01 16:13:56 -07:00
auto_roll_logger_test.cc Fix when output level is 0 of universal compaction with trivial move 2015-07-27 14:25:57 -07:00
autovector.h "make format" against last 10 commits 2015-07-13 13:50:18 -07:00
autovector_test.cc
bloom.cc
bloom_test.cc
build_version.h
cache.cc
cache_bench.cc
cache_test.cc
channel.h Multithreaded backup and restore in BackupEngineImpl 2015-07-02 11:35:51 -07:00
coding.cc
coding.h
coding_test.cc
compaction_job_stats_impl.cc Fix compaction_job_stats under ROCKSDB_LITE 2015-09-14 12:42:06 -07:00
comparator.cc Added Equal method to Comparator interface 2015-09-08 15:30:49 -07:00
compression.h Fixed minor issue in CompressionTypeSupported() 2015-09-09 16:36:19 -07:00
crc32c.cc Print Fast CRC32 support information in DB LOG 2015-07-10 17:59:36 -07:00
crc32c.h Print Fast CRC32 support information in DB LOG 2015-07-10 17:59:36 -07:00
crc32c_test.cc
db_info_dumper.cc extend temp str buffer size 2015-07-16 13:56:17 +08:00
db_info_dumper.h
db_test_util.cc Added Equal method to Comparator interface 2015-09-08 15:30:49 -07:00
db_test_util.h Refactor to support file_reader_writer on Windows. 2015-09-11 09:57:02 -07:00
delete_scheduler_impl.cc Rate limit deletes issued by DestroyDB 2015-08-19 15:02:17 -07:00
delete_scheduler_impl.h Rate limit deletes issued by DestroyDB 2015-08-19 15:02:17 -07:00
delete_scheduler_test.cc Rate limit deletes issued by DestroyDB 2015-08-19 15:02:17 -07:00
dynamic_bloom.cc
dynamic_bloom.h Commit both PR and internal code review changes 2015-07-07 16:58:20 -07:00
dynamic_bloom_test.cc
env.cc Ensure Windows build w/o port/port.h in public headers 2015-07-16 12:10:16 -07:00
env_hdfs.cc [Cleanup] Remove RandomRWFile 2015-08-12 10:18:59 -07:00
env_posix.cc Refactor to support file_reader_writer on Windows. 2015-09-11 09:57:02 -07:00
env_test.cc Refactor to support file_reader_writer on Windows. 2015-09-11 09:57:02 -07:00
event_logger.cc
event_logger.h Added JSON manifest dump option to ldb command 2015-07-17 10:07:40 -07:00
event_logger_test.cc
file_reader_writer.cc Address code review comments both GH and internal 2015-09-11 17:36:48 -07:00
file_reader_writer.h Address code review comments both GH and internal 2015-09-11 17:36:48 -07:00
file_reader_writer_test.cc Refactor to support file_reader_writer on Windows. 2015-09-11 09:57:02 -07:00
file_util.cc Rate limit deletes issued by DestroyDB 2015-08-19 15:02:17 -07:00
file_util.h Rate limit deletes issued by DestroyDB 2015-08-19 15:02:17 -07:00
filelock_test.cc
filter_policy.cc
hash.cc
hash.h
hash_cuckoo_rep.cc Added Equal method to Comparator interface 2015-09-08 15:30:49 -07:00
hash_cuckoo_rep.h
hash_linklist_rep.cc "make format" against last 10 commits 2015-07-13 13:50:18 -07:00
hash_linklist_rep.h
hash_skiplist_rep.cc
hash_skiplist_rep.h
heap.h Replace std::priority_queue in MergingIterator with custom heap, take 2 2015-07-15 03:34:40 -07:00
heap_test.cc Fix compile on Mac 2015-07-16 11:22:21 +02:00
histogram.cc
histogram.h "make format" against last 10 commits 2015-07-13 13:50:18 -07:00
histogram_test.cc
instrumented_mutex.cc
instrumented_mutex.h
iostats_context.cc Add options.compaction_measure_io_stats to print write I/O stats in compactions 2015-08-13 16:52:26 -07:00
iostats_context_imp.h
ldb_cmd.cc Fixed broken build due to format specifier 2015-09-08 15:46:16 -07:00
ldb_cmd.h Added JSON manifest dump option to ldb command 2015-07-17 10:07:40 -07:00
ldb_cmd_execute_result.h Windows Port from Microsoft 2015-07-01 16:13:56 -07:00
ldb_tool.cc
log_buffer.cc Commit both PR and internal code review changes 2015-07-07 16:58:20 -07:00
log_buffer.h Windows Port from Microsoft 2015-07-01 16:13:56 -07:00
log_write_bench.cc
logging.cc
logging.h
manual_compaction_test.cc Ensure Windows build w/o port/port.h in public headers 2015-07-16 12:10:16 -07:00
memenv.cc Refactor to support file_reader_writer on Windows. 2015-09-11 09:57:02 -07:00
memenv_test.cc Improved FileExists API 2015-07-20 17:20:40 -07:00
mock_env.cc Refactor to support file_reader_writer on Windows. 2015-09-11 09:57:02 -07:00
mock_env.h [Cleanup] Remove RandomRWFile 2015-08-12 10:18:59 -07:00
mock_env_test.cc Improved FileExists API 2015-07-20 17:20:40 -07:00
murmurhash.cc
murmurhash.h
mutable_cf_options.cc Add options.hard_pending_compaction_bytes_limit to stop writes if compaction lagging behind 2015-09-14 12:51:16 -07:00
mutable_cf_options.h Add options.hard_pending_compaction_bytes_limit to stop writes if compaction lagging behind 2015-09-14 12:51:16 -07:00
mutexlock.h
options.cc Fix valgrind error 2015-09-14 17:41:40 -07:00
options_builder.cc
options_helper.cc Add options.hard_pending_compaction_bytes_limit to stop writes if compaction lagging behind 2015-09-14 12:51:16 -07:00
options_helper.h Add options.hard_pending_compaction_bytes_limit to stop writes if compaction lagging behind 2015-09-14 12:51:16 -07:00
options_test.cc Add options.hard_pending_compaction_bytes_limit to stop writes if compaction lagging behind 2015-09-14 12:51:16 -07:00
perf_context.cc Ensure Windows build w/o port/port.h in public headers 2015-07-16 12:10:16 -07:00
perf_context_imp.h
perf_level.cc Windows Port from Microsoft 2015-07-01 16:13:56 -07:00
perf_level_imp.h Windows Port from Microsoft 2015-07-01 16:13:56 -07:00
perf_step_timer.h
posix_logger.h Commit both PR and internal code review changes 2015-07-07 16:58:20 -07:00
random.h
rate_limiter.cc Windows Port from Microsoft 2015-07-01 16:13:56 -07:00
rate_limiter.h Replace BackupRateLimiter with GenericRateLimiter 2015-09-03 17:00:09 -07:00
rate_limiter_test.cc
scoped_arena_iterator.h
skiplistrep.cc
slice.cc "make format" against last 10 commits 2015-07-13 13:50:18 -07:00
slice_transform_test.cc
sst_dump_test.cc Compression sizes option for sst_dump_tool 2015-07-29 17:42:13 -07:00
sst_dump_tool.cc Refactor NewTableReader to accept TableReaderOptions 2015-09-11 11:36:33 -07:00
sst_dump_tool_imp.h Compression sizes option for sst_dump_tool 2015-07-29 17:42:13 -07:00
statistics.cc Relax memory order for faster tickers 2015-09-15 10:52:00 -07:00
statistics.h Add Statistics.getHistogramString() to print more detailed outputs of a histogram 2015-08-05 20:05:56 -07:00
status.cc Support static Status messages 2015-08-31 16:13:29 -07:00
status_message.cc Support static Status messages 2015-08-31 16:13:29 -07:00
stl_wrappers.h Unified maps with Comparator for sorting, other cleanup 2015-09-02 13:58:22 -07:00
stop_watch.h
string_util.cc
string_util.h Windows Port from Microsoft 2015-07-01 16:13:56 -07:00
sync_point.cc Move rate_limiter, write buffering, most perf context instrumentation and most random kill out of Env 2015-07-17 16:58:18 -07:00
sync_point.h Move rate_limiter, write buffering, most perf context instrumentation and most random kill out of Env 2015-07-17 16:58:18 -07:00
testharness.cc
testharness.h
testutil.cc Simplify querying of merge results 2015-08-17 17:34:38 -07:00
testutil.h LogAndApply() should fail if the column family has been dropped 2015-09-15 11:28:44 -07:00
thread_list_test.cc
thread_local.cc Fixed clang-build error in util/thread_local.cc 2015-08-11 13:30:49 -07:00
thread_local.h Fixed clang-build error in util/thread_local.cc 2015-08-11 13:30:49 -07:00
thread_local_test.cc Windows Port from Microsoft 2015-07-01 16:13:56 -07:00
thread_operation.h Deprecate CompactionFilterV2 2015-07-17 18:59:11 +02:00
thread_status_impl.cc Windows Port from Microsoft 2015-07-01 16:13:56 -07:00
thread_status_updater.cc Windows Port from Microsoft 2015-07-01 16:13:56 -07:00
thread_status_updater.h Windows Port from Microsoft 2015-07-01 16:13:56 -07:00
thread_status_updater_debug.cc
thread_status_util.cc
thread_status_util.h
thread_status_util_debug.cc
vectorrep.cc Windows Port from Microsoft 2015-07-01 16:13:56 -07:00
xfunc.cc Merge the latest changes from github/master 2015-07-02 17:23:41 -07:00
xfunc.h Merge the latest changes from github/master 2015-07-02 17:23:41 -07:00
xxhash.cc
xxhash.h