rocksdb

History

Peter Dillinger 1aac814578 Use optimized folly DistributedMutex in LRUCache when available (#10179 ) Summary: folly DistributedMutex is faster than standard mutexes though imposes some static obligations on usage. See https://github.com/facebook/folly/blob/main/folly/synchronization/DistributedMutex.h for details. Here we use this alternative for our Cache implementations (especially LRUCache) for better locking performance, when RocksDB is compiled with folly. Also added information about which distributed mutex implementation is being used to cache_bench output and to DB LOG. Intended follow-up: * Use DMutex in more places, perhaps improving API to support non-scoped locking * Fix linking with fbcode compiler (needs ROCKSDB_NO_FBCODE=1 currently) Credit: Thanks Siying for reminding me about this line of work that was previously left unfinished. Pull Request resolved: https://github.com/facebook/rocksdb/pull/10179 Test Plan: for correctness, existing tests. CircleCI config updated. Also Meta-internal buck build updated. For performance, ran simultaneous before & after cache_bench. Out of three comparison runs, the middle improvement to ops/sec was +21%: Baseline: USE_CLANG=1 DEBUG_LEVEL=0 make -j24 cache_bench (fbcode compiler) ``` Complete in 20.201 s; Rough parallel ops/sec = 1584062 Thread ops/sec = 107176 Operation latency (ns): Count: 32000000 Average: 9257.9421 StdDev: 122412.04 Min: 134 Median: 3623.0493 Max: 56918500 Percentiles: P50: 3623.05 P75: 10288.02 P99: 30219.35 P99.9: 683522.04 P99.99: 7302791.63 ``` New: (add USE_FOLLY=1) ``` Complete in 16.674 s; Rough parallel ops/sec = 1919135 (+21%) Thread ops/sec = 135487 Operation latency (ns): Count: 32000000 Average: 7304.9294 StdDev: 108530.28 Min: 132 Median: 3777.6012 Max: 91030902 Percentiles: P50: 3777.60 P75: 10169.89 P99: 24504.51 P99.9: 59721.59 P99.99: 1861151.83 ``` Reviewed By: anand1976 Differential Revision: D37182983 Pulled By: pdillinger fbshipit-source-id: a17eb05f25b832b6a2c1356f5c657e831a5af8d1		2022-06-17 13:08:45 -07:00
..
win	Use optimized folly DistributedMutex in LRUCache when available (#10179 )	2022-06-17 13:08:45 -07:00
README	reverting disastrous MOE commit, returning to r21	2011-04-19 23:11:15 +00:00
jemalloc_helper.h	jemalloc_helper: Limit the mm_malloc.h hack to glibc on linux (#8425 )	2021-06-29 08:40:02 -07:00
lang.h	Meta-internal folly integration with F14FastMap (#9546 )	2022-04-13 07:34:01 -07:00
likely.h	Support pragma once in all header files and cleanup some warnings (#4339 )	2018-09-05 18:13:31 -07:00
malloc.h	Charge block cache for cache internal usage (#5797 )	2019-09-16 15:26:21 -07:00
port.h	Change RocksDB License	2017-07-15 16:11:23 -07:00
port_dirent.h	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433 )	2020-02-20 12:09:57 -08:00
port_example.h	Replace most typedef with using= (#8751 )	2021-09-07 11:31:59 -07:00
port_posix.cc	Prevent deadlock in db_stress with DbStressCompactionFilter (#8956 )	2021-09-24 16:54:02 -07:00
port_posix.h	Use optimized folly DistributedMutex in LRUCache when available (#10179 )	2022-06-17 13:08:45 -07:00
stack_trace.cc	Standardize on GCC for TSAN conditional compilation (#8543 )	2021-07-15 23:50:00 -07:00
stack_trace.h	Fault injection in db_stress (#6538 )	2020-04-10 17:21:26 -07:00
sys_time.h	Fix potential ambiguities in/around port/sys_time.h (#10045 )	2022-05-24 18:20:17 -07:00
util_logger.h	Move some logging related files to logging/ (#5387 )	2019-05-31 17:23:59 -07:00
xpress.h	Change RocksDB License	2017-07-15 16:11:23 -07:00

README

This directory contains interfaces and implementations that isolate the
rest of the package from platform details.

Code in the rest of the package includes "port.h" from this directory.
"port.h" in turn includes a platform specific "port_<platform>.h" file
that provides the platform specific implementation.

See port_posix.h for an example of what must be provided in a platform
specific header file.