mirror of https://github.com/facebook/rocksdb.git
62247ffa3b
Summary: When using latest clang (3.6 or 3.7/trunck) rocksdb is failing with many errors. Almost all of them are missing override errors. This diff adds missing override keyword. No manual changes. Prerequisites: bear and clang 3.5 build with extra tools ```lang=bash % USE_CLANG=1 bear make all # generate a compilation database http://clang.llvm.org/docs/JSONCompilationDatabase.html % clang-modernize -p . -include . -add-override % make format ``` Test Plan: Make sure all tests are passing. ```lang=bash % #Use default fb code clang. % make check ``` Verify less error and no missing override errors. ```lang=bash % # Have trunk clang present in path. % ROCKSDB_NO_FBCODE=1 CC=clang CXX=clang++ make ``` Reviewers: igor, kradhakrishnan, rven, meyering, sdong Reviewed By: sdong Subscribers: dhruba, leveldb Differential Revision: https://reviews.facebook.net/D34077 |
||
|---|---|---|
| .. | ||
| README | ||
| redis_list_exception.h | ||
| redis_list_iterator.h | ||
| redis_lists.cc | ||
| redis_lists.h | ||
| redis_lists_test.cc | ||
README
This folder defines a REDIS-style interface for Rocksdb. Right now it is written as a simple tag-on in the rocksdb::RedisLists class. It implements Redis Lists, and supports only the "non-blocking operations". Internally, the set of lists are stored in a rocksdb database, mapping keys to values. Each "value" is the list itself, storing a sequence of "elements". Each element is stored as a 32-bit-integer, followed by a sequence of bytes. The 32-bit-integer represents the length of the element (that is, the number of bytes that follow). And then that many bytes follow. NOTE: This README file may be old. See the actual redis_lists.cc file for definitive details on the implementation. There should be a header at the top of that file, explaining a bit of the implementation details.