mirror of
https://github.com/facebook/rocksdb.git
synced 2024-11-25 22:44:05 +00:00
fe9d495112
Summary: This fix addresses https://github.com/facebook/rocksdb/issues/9299. If attempting to create a new object via the ObjectRegistry and a factory is not found, the ObjectRegistry will return a "NotSupported" status. This is the same behavior as previously. If the factory is found but could not successfully create the object, an "InvalidArgument" status is returned. If the factory returned a reason why (in the errmsg), this message will be in the returned status. In practice, there are two options in the ConfigOptions that control how these errors are propagated: - If "ignore_unknown_options=true", then both InvalidArgument and NotSupported status codes will be swallowed internally. Both cases will return success - If "ignore_unsupported_options=true", then having no factory will return success but a failing factory will return an error - If both options are false, both cases (no and failing factory) will return errors. In practice this likely only changes Customizable that may be partially available. For example, the JEMallocMemoryAllocator is a built-in allocator that is registered with the system but may not be compiled in. In this case, the status code for this allocator changed from NotSupported("JEMalloc not available") to InvalidArgumen("JEMalloc not available"). Other Customizable builtins/plugins would have the same semantics. Pull Request resolved: https://github.com/facebook/rocksdb/pull/9333 Reviewed By: pdillinger Differential Revision: D33517681 Pulled By: mrambacher fbshipit-source-id: 8033052d4a4a7b88c2d9f90147b1b4467e51f6fd |
||
|---|---|---|
| .. | ||
| composite_env.cc | ||
| composite_env_wrapper.h | ||
| emulated_clock.h | ||
| env.cc | ||
| env_basic_test.cc | ||
| env_chroot.cc | ||
| env_chroot.h | ||
| env_encryption.cc | ||
| env_encryption_ctr.h | ||
| env_posix.cc | ||
| env_test.cc | ||
| file_system.cc | ||
| file_system_tracer.cc | ||
| file_system_tracer.h | ||
| fs_posix.cc | ||
| fs_readonly.h | ||
| fs_remap.cc | ||
| fs_remap.h | ||
| io_posix.cc | ||
| io_posix.h | ||
| io_posix_test.cc | ||
| mock_env.cc | ||
| mock_env.h | ||
| mock_env_test.cc | ||
| unique_id_gen.cc | ||
| unique_id_gen.h | ||