mirror of https://github.com/facebook/rocksdb.git
9a034801ce
Summary:
**Context/Summary:**
- Similar to https://github.com/facebook/rocksdb/pull/11288 but for user read such as `Get(), MultiGet(), DBIterator::XXX(), Verify(File)Checksum()`.
- For this, I refactored some user-facing `MultiGet` calls in `TransactionBase` and various types of `DB` so that it does not call a user-facing `Get()` but `GetImpl()` for passing the `ReadOptions::io_activity` check (see PR conversation)
- New user read stats breakdown are guarded by `kExceptDetailedTimers` since measurement shows they have 4-5% regression to the upstream/main.
- Misc
- More refactoring: with https://github.com/facebook/rocksdb/pull/11288, we complete passing `ReadOptions/IOOptions` to FS level. So we can now replace the previously [added](https://github.com/facebook/rocksdb/pull/9424) `rate_limiter_priority` parameter in `RandomAccessFileReader`'s `Read/MultiRead/Prefetch()` with `IOOptions::rate_limiter_priority`
- Also, `ReadAsync()` call time is measured in `SST_READ_MICRO` now
Pull Request resolved: https://github.com/facebook/rocksdb/pull/11444
Test Plan:
- CI fake db crash/stress test
- Microbenchmarking
**Build** `make clean && ROCKSDB_NO_FBCODE=1 DEBUG_LEVEL=0 make -jN db_basic_bench`
- google benchmark version:
|
||
|---|---|---|
| .. | ||
| CMakeLists.txt | ||
| batched_ops_stress.cc | ||
| cf_consistency_stress.cc | ||
| db_stress.cc | ||
| db_stress_common.cc | ||
| db_stress_common.h | ||
| db_stress_compaction_filter.h | ||
| db_stress_driver.cc | ||
| db_stress_driver.h | ||
| db_stress_env_wrapper.h | ||
| db_stress_gflags.cc | ||
| db_stress_listener.cc | ||
| db_stress_listener.h | ||
| db_stress_shared_state.cc | ||
| db_stress_shared_state.h | ||
| db_stress_stat.cc | ||
| db_stress_stat.h | ||
| db_stress_table_properties_collector.h | ||
| db_stress_test_base.cc | ||
| db_stress_test_base.h | ||
| db_stress_tool.cc | ||
| expected_state.cc | ||
| expected_state.h | ||
| expected_value.cc | ||
| expected_value.h | ||
| multi_ops_txns_stress.cc | ||
| multi_ops_txns_stress.h | ||
| no_batched_ops_stress.cc | ||