mirror of
https://github.com/facebook/rocksdb.git
synced 2024-11-30 04:41:49 +00:00
75133b1b6b
Summary:
Since `SstFileReader` don't know largest seqno of a file, it will fail this check when it open a file with global seqno: ca89ac2ba9/table/block_based_table_reader.cc (L730)
Changes:
* Pass largest_seqno=kMaxSequenceNumber from `SstFileReader` and allow it to bypass the above check.
* `BlockBasedTable::VerifyChecksum` also double check if checksum will match when excluding global seqno (this is to make the new test in sst_table_reader_test pass).
Pull Request resolved: https://github.com/facebook/rocksdb/pull/5097
Differential Revision: D14607434
Pulled By: riversand963
fbshipit-source-id: 9008599227c5fccbf9b73fee46b3bf4a1523f023
95 lines
3.1 KiB
C++
95 lines
3.1 KiB
C++
// Copyright (c) 2011-present, Facebook, Inc. All rights reserved.
|
|
// This source code is licensed under both the GPLv2 (found in the
|
|
// COPYING file in the root directory) and Apache 2.0 License
|
|
// (found in the LICENSE.Apache file in the root directory).
|
|
|
|
#pragma once
|
|
#include <string>
|
|
#include "db/dbformat.h"
|
|
#include "db/table_properties_collector.h"
|
|
#include "rocksdb/types.h"
|
|
#include "util/string_util.h"
|
|
|
|
namespace rocksdb {
|
|
|
|
// Table Properties that are specific to tables created by SstFileWriter.
|
|
struct ExternalSstFilePropertyNames {
|
|
// value of this property is a fixed uint32 number.
|
|
static const std::string kVersion;
|
|
// value of this property is a fixed uint64 number.
|
|
static const std::string kGlobalSeqno;
|
|
};
|
|
|
|
// PropertiesCollector used to add properties specific to tables
|
|
// generated by SstFileWriter
|
|
class SstFileWriterPropertiesCollector : public IntTblPropCollector {
|
|
public:
|
|
explicit SstFileWriterPropertiesCollector(int32_t version,
|
|
SequenceNumber global_seqno)
|
|
: version_(version), global_seqno_(global_seqno) {}
|
|
|
|
virtual Status InternalAdd(const Slice& /*key*/, const Slice& /*value*/,
|
|
uint64_t /*file_size*/) override {
|
|
// Intentionally left blank. Have no interest in collecting stats for
|
|
// individual key/value pairs.
|
|
return Status::OK();
|
|
}
|
|
|
|
virtual void BlockAdd(uint64_t /* blockRawBytes */,
|
|
uint64_t /* blockCompressedBytesFast */,
|
|
uint64_t /* blockCompressedBytesSlow */) override {
|
|
// Intentionally left blank. No interest in collecting stats for
|
|
// blocks.
|
|
return;
|
|
}
|
|
|
|
virtual Status Finish(UserCollectedProperties* properties) override {
|
|
// File version
|
|
std::string version_val;
|
|
PutFixed32(&version_val, static_cast<uint32_t>(version_));
|
|
properties->insert({ExternalSstFilePropertyNames::kVersion, version_val});
|
|
|
|
// Global Sequence number
|
|
std::string seqno_val;
|
|
PutFixed64(&seqno_val, static_cast<uint64_t>(global_seqno_));
|
|
properties->insert({ExternalSstFilePropertyNames::kGlobalSeqno, seqno_val});
|
|
|
|
return Status::OK();
|
|
}
|
|
|
|
virtual const char* Name() const override {
|
|
return "SstFileWriterPropertiesCollector";
|
|
}
|
|
|
|
virtual UserCollectedProperties GetReadableProperties() const override {
|
|
return {{ExternalSstFilePropertyNames::kVersion, ToString(version_)}};
|
|
}
|
|
|
|
private:
|
|
int32_t version_;
|
|
SequenceNumber global_seqno_;
|
|
};
|
|
|
|
class SstFileWriterPropertiesCollectorFactory
|
|
: public IntTblPropCollectorFactory {
|
|
public:
|
|
explicit SstFileWriterPropertiesCollectorFactory(int32_t version,
|
|
SequenceNumber global_seqno)
|
|
: version_(version), global_seqno_(global_seqno) {}
|
|
|
|
virtual IntTblPropCollector* CreateIntTblPropCollector(
|
|
uint32_t /*column_family_id*/) override {
|
|
return new SstFileWriterPropertiesCollector(version_, global_seqno_);
|
|
}
|
|
|
|
virtual const char* Name() const override {
|
|
return "SstFileWriterPropertiesCollector";
|
|
}
|
|
|
|
private:
|
|
int32_t version_;
|
|
SequenceNumber global_seqno_;
|
|
};
|
|
|
|
} // namespace rocksdb
|