mirror of
https://github.com/facebook/rocksdb.git
synced 2024-11-25 22:44:05 +00:00
933ac0e05c
Summary: In `SaveValue()`, the read lock needs to be obtained before `VerifyEntryChecksum()` because the KV checksum verification reads the entire value metadata+data, which is all mutable when `ColumnFamilyOptions::inplace_update_support == true`. In `MemTable::Update()`, the write lock needs to be obtained before mutating the value metadata (changing the value size) because it can be read concurrently. Pull Request resolved: https://github.com/facebook/rocksdb/pull/12624 Test Plan: ``` $ make COMPILE_WITH_TSAN=1 -j56 db_stress ... $ python3 tools/db_crashtest.py blackbox --simple --max_key=10 --inplace_update_support=1 --interval=10 --allow_concurrent_memtable_write=0 ``` Reviewed By: cbi42 Differential Revision: D57034571 Pulled By: ajkr fbshipit-source-id: 3dddf881ad87923143acdf6bfec12ce47bb13a48 |
||
|---|---|---|
| .. | ||
| batched_ops_stress.cc | ||
| cf_consistency_stress.cc | ||
| CMakeLists.txt | ||
| db_stress.cc | ||
| db_stress_common.cc | ||
| db_stress_common.h | ||
| db_stress_compaction_filter.h | ||
| db_stress_driver.cc | ||
| db_stress_driver.h | ||
| db_stress_env_wrapper.h | ||
| db_stress_gflags.cc | ||
| db_stress_listener.cc | ||
| db_stress_listener.h | ||
| db_stress_shared_state.cc | ||
| db_stress_shared_state.h | ||
| db_stress_stat.cc | ||
| db_stress_stat.h | ||
| db_stress_table_properties_collector.h | ||
| db_stress_test_base.cc | ||
| db_stress_test_base.h | ||
| db_stress_tool.cc | ||
| db_stress_wide_merge_operator.cc | ||
| db_stress_wide_merge_operator.h | ||
| expected_state.cc | ||
| expected_state.h | ||
| expected_value.cc | ||
| expected_value.h | ||
| multi_ops_txns_stress.cc | ||
| multi_ops_txns_stress.h | ||
| no_batched_ops_stress.cc | ||