mirror of
https://github.com/facebook/rocksdb.git
synced 2024-11-27 02:44:18 +00:00
9a690a74e1
Summary: Fixes Issue https://github.com/facebook/rocksdb/issues/7497 When allow_data_in_errors db_options is set, log error key details in `ParseInternalKey()` Have fixed most of the calls. Have few TODOs still pending - because have to make more deeper changes to pass in the allow_data_in_errors flag. Will do those in a separate PR later. Tests: - make check - some of the existing tests that exercise the "internal key too small" condition are: dbformat_test, cuckoo_table_builder_test - some of the existing tests that exercise the corrupted key path are: corruption_test, merge_helper_test, compaction_iterator_test Example of new status returns: - Key too small - `Corrupted Key: Internal Key too small. Size=5` - Corrupt key with allow_data_in_errors option set to false: `Corrupted Key: '<redacted>' seq:3, type:3` - Corrupt key with allow_data_in_errors option set to true: `Corrupted Key: '61' seq:3, type:3` Pull Request resolved: https://github.com/facebook/rocksdb/pull/7515 Reviewed By: ajkr Differential Revision: D24240264 Pulled By: ramvadiv fbshipit-source-id: bc48f5d4475ac19d7713e16df37505b31aac42e7
83 lines
2.6 KiB
C++
83 lines
2.6 KiB
C++
// Copyright (c) 2011-present, Facebook, Inc. All rights reserved.
|
|
// This source code is licensed under both the GPLv2 (found in the
|
|
// COPYING file in the root directory) and Apache 2.0 License
|
|
// (found in the LICENSE.Apache file in the root directory).
|
|
|
|
#ifndef ROCKSDB_LITE
|
|
|
|
#include "rocksdb/utilities/debug.h"
|
|
|
|
#include "db/db_impl/db_impl.h"
|
|
|
|
namespace ROCKSDB_NAMESPACE {
|
|
|
|
Status GetAllKeyVersions(DB* db, Slice begin_key, Slice end_key,
|
|
size_t max_num_ikeys,
|
|
std::vector<KeyVersion>* key_versions) {
|
|
if (nullptr == db) {
|
|
return Status::InvalidArgument("db cannot be null.");
|
|
}
|
|
return GetAllKeyVersions(db, db->DefaultColumnFamily(), begin_key, end_key,
|
|
max_num_ikeys, key_versions);
|
|
}
|
|
|
|
Status GetAllKeyVersions(DB* db, ColumnFamilyHandle* cfh, Slice begin_key,
|
|
Slice end_key, size_t max_num_ikeys,
|
|
std::vector<KeyVersion>* key_versions) {
|
|
if (nullptr == db) {
|
|
return Status::InvalidArgument("db cannot be null.");
|
|
}
|
|
if (nullptr == cfh) {
|
|
return Status::InvalidArgument("Column family handle cannot be null.");
|
|
}
|
|
if (nullptr == key_versions) {
|
|
return Status::InvalidArgument("key_versions cannot be null.");
|
|
}
|
|
key_versions->clear();
|
|
|
|
DBImpl* idb = static_cast<DBImpl*>(db->GetRootDB());
|
|
auto icmp = InternalKeyComparator(idb->GetOptions(cfh).comparator);
|
|
ReadOptions read_options;
|
|
ReadRangeDelAggregator range_del_agg(&icmp,
|
|
kMaxSequenceNumber /* upper_bound */);
|
|
Arena arena;
|
|
ScopedArenaIterator iter(idb->NewInternalIterator(
|
|
read_options, &arena, &range_del_agg, kMaxSequenceNumber, cfh));
|
|
|
|
if (!begin_key.empty()) {
|
|
InternalKey ikey;
|
|
ikey.SetMinPossibleForUserKey(begin_key);
|
|
iter->Seek(ikey.Encode());
|
|
} else {
|
|
iter->SeekToFirst();
|
|
}
|
|
|
|
size_t num_keys = 0;
|
|
for (; iter->Valid(); iter->Next()) {
|
|
ParsedInternalKey ikey;
|
|
Status pik_status =
|
|
ParseInternalKey(iter->key(), &ikey, true /* log_err_key */); // TODO
|
|
if (!pik_status.ok()) {
|
|
return pik_status;
|
|
}
|
|
|
|
if (!end_key.empty() &&
|
|
icmp.user_comparator()->Compare(ikey.user_key, end_key) > 0) {
|
|
break;
|
|
}
|
|
|
|
key_versions->emplace_back(ikey.user_key.ToString() /* _user_key */,
|
|
iter->value().ToString() /* _value */,
|
|
ikey.sequence /* _sequence */,
|
|
static_cast<int>(ikey.type) /* _type */);
|
|
if (++num_keys >= max_num_ikeys) {
|
|
break;
|
|
}
|
|
}
|
|
return Status::OK();
|
|
}
|
|
|
|
} // namespace ROCKSDB_NAMESPACE
|
|
|
|
#endif // ROCKSDB_LITE
|