rocksdb/options
Andrew Kryczka e576f2ab19 Fix race conditions in GenericRateLimiter (#10374)
Summary:
Made locking strict for all accesses of `GenericRateLimiter` internal state.

`SetBytesPerSecond()` was the main problem since it had no locking, while the two updates it makes need to be done as one atomic operation.

The test case, "ConfigOptionsTest.ConfiguringOptionsDoesNotRevertRateLimiterBandwidth", is for the issue fixed in https://github.com/facebook/rocksdb/issues/10378, but I forgot to include the test there.

Pull Request resolved: https://github.com/facebook/rocksdb/pull/10374

Reviewed By: pdillinger

Differential Revision: D37906367

Pulled By: ajkr

fbshipit-source-id: ccde620d2a7f96d1401bdafd2bdb685cbefbafa5
2022-07-19 09:31:14 -07:00
..
cf_options.cc Support prepopulating/warming the blob cache (#10298) 2022-07-17 07:13:59 -07:00
cf_options.h Support prepopulating/warming the blob cache (#10298) 2022-07-17 07:13:59 -07:00
configurable.cc Option type info functions (#9411) 2022-05-13 04:57:08 -07:00
configurable_helper.h Fix some minor issues in the Customizable infrastructure (#8566) 2021-08-19 10:10:47 -07:00
configurable_test.cc Remove own ToString() (#9955) 2022-05-06 13:03:58 -07:00
configurable_test.h Move RegisterOptions into the Configurable API (#8223) 2021-04-26 03:13:24 -07:00
customizable.cc Option type info functions (#9411) 2022-05-13 04:57:08 -07:00
customizable_test.cc Make RateLimiter not Customizable (#10378) 2022-07-18 14:48:42 -07:00
db_options.cc Make RateLimiter not Customizable (#10378) 2022-07-18 14:48:42 -07:00
db_options.h Dynamically changeable `MemPurge` option (#10011) 2022-06-23 09:42:18 -07:00
options.cc Support prepopulating/warming the blob cache (#10298) 2022-07-17 07:13:59 -07:00
options_helper.cc Support prepopulating/warming the blob cache (#10298) 2022-07-17 07:13:59 -07:00
options_helper.h Support prepopulating/warming the blob cache (#10298) 2022-07-17 07:13:59 -07:00
options_parser.cc fix a false positive case of parsing table factory from options file (#10094) 2022-06-14 13:20:54 -07:00
options_parser.h Bring the Configurable options together (#5753) 2020-09-14 17:01:01 -07:00
options_settable_test.cc Support prepopulating/warming the blob cache (#10298) 2022-07-17 07:13:59 -07:00
options_test.cc Fix race conditions in GenericRateLimiter (#10374) 2022-07-19 09:31:14 -07:00