mirror of
https://github.com/facebook/rocksdb.git
synced 2024-11-30 04:41:49 +00:00
babe56ddba
Summary: Users can set the priority for file reads associated with their operation by setting `ReadOptions::rate_limiter_priority` to something other than `Env::IO_TOTAL`. Rate limiting `VerifyChecksum()` and `VerifyFileChecksums()` is the motivation for this PR, so it also includes benchmarks and minor bug fixes to get that working. `RandomAccessFileReader::Read()` already had support for rate limiting compaction reads. I changed that rate limiting to be non-specific to compaction, but rather performed according to the passed in `Env::IOPriority`. Now the compaction read rate limiting is supported by setting `rate_limiter_priority = Env::IO_LOW` on its `ReadOptions`. There is no default value for the new `Env::IOPriority` parameter to `RandomAccessFileReader::Read()`. That means this PR goes through all callers (in some cases multiple layers up the call stack) to find a `ReadOptions` to provide the priority. There are TODOs for cases I believe it would be good to let user control the priority some day (e.g., file footer reads), and no TODO in cases I believe it doesn't matter (e.g., trace file reads). The API doc only lists the missing cases where a file read associated with a provided `ReadOptions` cannot be rate limited. For cases like file ingestion checksum calculation, there is no API to provide `ReadOptions` or `Env::IOPriority`, so I didn't count that as missing. Pull Request resolved: https://github.com/facebook/rocksdb/pull/9424 Test Plan: - new unit tests - new benchmarks on ~50MB database with 1MB/s read rate limit and 100ms refill interval; verified with strace reads are chunked (at 0.1MB per chunk) and spaced roughly 100ms apart. - setup command: `./db_bench -benchmarks=fillrandom,compact -db=/tmp/testdb -target_file_size_base=1048576 -disable_auto_compactions=true -file_checksum=true` - benchmarks command: `strace -ttfe pread64 ./db_bench -benchmarks=verifychecksum,verifyfilechecksums -use_existing_db=true -db=/tmp/testdb -rate_limiter_bytes_per_sec=1048576 -rate_limit_bg_reads=1 -rate_limit_user_ops=true -file_checksum=true` - crash test using IO_USER priority on non-validation reads with https://github.com/facebook/rocksdb/issues/9567 reverted: `python3 tools/db_crashtest.py blackbox --max_key=1000000 --write_buffer_size=524288 --target_file_size_base=524288 --level_compaction_dynamic_level_bytes=true --duration=3600 --rate_limit_bg_reads=true --rate_limit_user_ops=true --rate_limiter_bytes_per_sec=10485760 --interval=10` Reviewed By: hx235 Differential Revision: D33747386 Pulled By: ajkr fbshipit-source-id: a2d985e97912fba8c54763798e04f006ccc56e0c |
||
|---|---|---|
| .. | ||
| blob_constants.h | ||
| blob_counting_iterator.h | ||
| blob_counting_iterator_test.cc | ||
| blob_fetcher.cc | ||
| blob_fetcher.h | ||
| blob_file_addition.cc | ||
| blob_file_addition.h | ||
| blob_file_addition_test.cc | ||
| blob_file_builder.cc | ||
| blob_file_builder.h | ||
| blob_file_builder_test.cc | ||
| blob_file_cache.cc | ||
| blob_file_cache.h | ||
| blob_file_cache_test.cc | ||
| blob_file_completion_callback.h | ||
| blob_file_garbage.cc | ||
| blob_file_garbage.h | ||
| blob_file_garbage_test.cc | ||
| blob_file_meta.cc | ||
| blob_file_meta.h | ||
| blob_file_reader.cc | ||
| blob_file_reader.h | ||
| blob_file_reader_test.cc | ||
| blob_garbage_meter.cc | ||
| blob_garbage_meter.h | ||
| blob_garbage_meter_test.cc | ||
| blob_index.h | ||
| blob_log_format.cc | ||
| blob_log_format.h | ||
| blob_log_sequential_reader.cc | ||
| blob_log_sequential_reader.h | ||
| blob_log_writer.cc | ||
| blob_log_writer.h | ||
| db_blob_basic_test.cc | ||
| db_blob_compaction_test.cc | ||
| db_blob_corruption_test.cc | ||
| db_blob_index_test.cc | ||
| prefetch_buffer_collection.cc | ||
| prefetch_buffer_collection.h | ||