dolysis
/
rocksdb
mirror of https://github.com/facebook/rocksdb.git
3
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
2,212 Commits 196 Branches 277 Tags 388 MiB
C++ 84.3%
Java 9.6%
C 1.6%
Python 1.5%
Perl 0.9%
Other 2%
Go to file
Igor Canadi 88841bd007 Explicitly cast char to signed char in Hash() 
Summary:
The compilers we use treat char as signed. However, this is not guarantee of C standard and some compilers (for ARM platform for example), treat char as unsigned. Code that assumes that char is either signed or unsigned is wrong.

This change explicitly casts the char to signed version. This will not break any of our use cases on x86, which, I believe are all of them. In case somebody out there is using RocksDB on ARM AND using bloom filters, they're going to have a bad time. However, it is very unlikely that this is the case.

Test Plan: sanity test with previous commit (with new sanity test)

Reviewers: yhchiang, ljin, sdong

Reviewed By: ljin

Subscribers: dhruba, leveldb

Differential Revision: https://reviews.facebook.net/D22767
 		2014-09-08 18:57:40 -07:00
build_tools Add db_bench with lots of column families to regression tests 2014-09-05 14:20:18 -07:00
coverage Disable the html-based coverage report by default 2014-02-06 12:58:13 -08:00
db MemTableOptions 2014-09-08 18:46:52 -07:00
doc Remove seek compaction 2014-06-20 10:23:02 +02:00
examples Make it easier to start using RocksDB 2014-05-10 10:49:33 -07:00
hdfs hdfs cleanup and compile test against CDH 4.4. 2014-05-20 17:22:12 -04:00
helpers/memenv Expose in memory Env to the world 2014-04-14 12:28:15 -07:00
include MemTableOptions 2014-09-08 18:46:52 -07:00
java Remove path with arena==nullptr from NewInternalIterator 2014-09-04 17:40:41 -07:00
linters allow lambda function syntax in cpplint 2014-02-20 12:47:05 -08:00
port Avoid off-by-one error when using readlink 2014-09-05 20:50:29 -07:00
table MemTableOptions 2014-09-08 18:46:52 -07:00
third-party/rapidjson Fix a rapidjson compile error in mac. 2014-06-23 17:09:24 -06:00
tools Explicitly cast char to signed char in Hash() 2014-09-08 18:57:40 -07:00
util Explicitly cast char to signed char in Hash() 2014-09-08 18:57:40 -07:00
utilities Some updates for SpatialDB 2014-09-08 17:00:43 -07:00
.arcconfig Improve/fix bugs for the cpp linter 2014-02-13 17:48:11 -08:00
.clang-format A script that automatically reformat affected lines 2014-01-14 12:21:24 -08:00
.gitignore Changes to support unity build: 2014-08-11 13:22:47 -04:00
.travis.yml Fix travis builds 2014-09-04 10:23:45 -07:00
CONTRIBUTING.md facebook accounts are not required for CLA signers 2014-07-08 05:57:54 -04:00
HISTORY.md Explicitly cast char to signed char in Hash() 2014-09-08 18:57:40 -07:00
INSTALL.md specify the command to install build_tools/mac-install-gflags.sh file in doc 2014-06-17 17:03:21 -05:00
LICENSE Fix copyright year 2014-03-12 12:06:58 -07:00
Makefile Push- instead of pull-model for managing Write stalls 2014-09-08 11:20:25 -07:00
PATENTS Fix the patent format 2013-10-16 15:37:32 -07:00
README.md Update README.md 2014-06-23 15:58:54 -07:00
ROCKSDB_LITE.md RocksDBLite 2014-04-15 13:39:26 -07:00

README.md

RocksDB: A Persistent Key-Value Store for Flash and RAM Storage

Build Status

RocksDB is developed and maintained by Facebook Database Engineering Team. It is built on on earlier work on LevelDB by Sanjay Ghemawat (sanjay@google.com) and Jeff Dean (jeff@google.com)

This code is a library that forms the core building block for a fast key value server, especially suited for storing data on flash drives. It has a Log-Structured-Merge-Database (LSM) design with flexible tradeoffs between Write-Amplification-Factor (WAF), Read-Amplification-Factor (RAF) and Space-Amplification-Factor (SAF). It has multi-threaded compactions, making it specially suitable for storing multiple terabytes of data in a single database.

Start with example usage here: https://github.com/facebook/rocksdb/tree/master/examples

See the github wiki for more explanation.

The public interface is in include/. Callers should not include or rely on the details of any other header files in this package. Those internal APIs may be changed without warning.

Design discussions are conducted in https://www.facebook.com/groups/rocksdb.dev/