rocksdb/logging
Peter Dillinger 4e60663b31 Remove unnecessary, confusing 'extern' (#12300)
Summary:
In C++, `extern` is redundant in a number of cases:
* "Global" function declarations and definitions
* "Global" variable definitions when already declared `extern`

For consistency and simplicity, I've removed these in code that *we own*. In a couple of cases, I removed obsolete declarations, and for MagicNumber constants, I have consolidated the declarations into a header file (format.h)
as standard best practice would prescribe.

Pull Request resolved: https://github.com/facebook/rocksdb/pull/12300

Test Plan: no functional changes, CI

Reviewed By: ajkr

Differential Revision: D53148629

Pulled By: pdillinger

fbshipit-source-id: fb8d927959892e03af09b0c0d542b0a3b38fd886
2024-01-29 10:38:08 -08:00
..
auto_roll_logger.cc Remove RocksDB LITE (#11147) 2023-01-27 13:14:19 -08:00
auto_roll_logger.h Remove RocksDB LITE (#11147) 2023-01-27 13:14:19 -08:00
auto_roll_logger_test.cc internal_repo_rocksdb (-8794174668376270091) (#12114) 2023-12-01 11:10:30 -08:00
env_logger.h Group SST write in flush, compaction and db open with new stats (#11910) 2023-12-29 15:29:23 -08:00
env_logger_test.cc internal_repo_rocksdb (-8794174668376270091) (#12114) 2023-12-01 11:10:30 -08:00
event_logger.cc Run clang format on logging folder (#10861) 2022-10-24 18:13:43 -07:00
event_logger.h Run clang format on logging folder (#10861) 2022-10-24 18:13:43 -07:00
event_logger_test.cc Run clang format on logging folder (#10861) 2022-10-24 18:13:43 -07:00
log_buffer.cc Run clang format on logging folder (#10861) 2022-10-24 18:13:43 -07:00
log_buffer.h Remove unnecessary, confusing 'extern' (#12300) 2024-01-29 10:38:08 -08:00
logging.h Observe and warn about misconfigured HyperClockCache (#10965) 2022-11-21 12:08:21 -08:00