Changyu Bi bc04ec85db Make option level_compaction_dynamic_level_bytes true by default (#11525) ... Summary: after https://github.com/facebook/rocksdb/issues/11321 and https://github.com/facebook/rocksdb/issues/11340 (both included in RocksDB v8.2), migration from `level_compaction_dynamic_level_bytes=false` to `level_compaction_dynamic_level_bytes=true` is automatic by RocksDB and requires no manual compaction from user. Making the option true by default as it has several advantages: 1. better space amplification guarantee (a more stable LSM shape). 2. compaction is more adaptive to write traffic. 3. automatic draining of unneeded levels. Wiki is updated with more detail: https://github.com/facebook/rocksdb/wiki/Leveled-Compaction#option-level_compaction_dynamic_level_bytes-and-levels-target-size. The PR mostly contains fixes for unit tests as they assumed `level_compaction_dynamic_level_bytes=false`. Most notable change is commit f742be330c and b1928e42b3 which override the default option in DBTestBase to still set `level_compaction_dynamic_level_bytes=false` by default. This helps to reduce the change needed for unit tests. I think this default option override in unit tests is okay since the behavior of `level_compaction_dynamic_level_bytes=true` is tested by explicitly setting this option. Also, `level_compaction_dynamic_level_bytes=false` may be more desired in unit tests as it makes it easier to create a desired LSM shape. Comment for option `level_compaction_dynamic_level_bytes` is updated to reflect this change and change made in https://github.com/facebook/rocksdb/issues/10057. Pull Request resolved: https://github.com/facebook/rocksdb/pull/11525 Test Plan: `make -j32 J=32 check` several times to try to catch flaky tests due to this option change. Reviewed By: ajkr Differential Revision: D46654256 Pulled By: cbi42 fbshipit-source-id: 6b5827dae124f6f1fdc8cca2ac6f6fcd878830e1		2023-06-15 21:12:39 -07:00
..
benchmark/src/main/java/org/rocksdb/benchmark
crossbuild
jmh
rocksjni	Implement missing compactrangeoptions from Java API (#10880)	2023-05-24 11:04:46 -07:00
samples/src/main/java
src	Make option level_compaction_dynamic_level_bytes true by default (#11525)	2023-06-15 21:12:39 -07:00
CMakeLists.txt	Set -source 8 in CMAKE_JAVA_COMPILE_FLAGS (#11385)	2023-04-18 11:15:25 -07:00
GetBenchmarks.md
HISTORY-JAVA.md
jdb_bench.sh
Makefile
pom.xml.template
RELEASE.md
understanding_options.md