mirror of
https://github.com/facebook/rocksdb.git
synced 2024-11-30 04:41:49 +00:00
9a034801ce
Summary:
**Context/Summary:**
- Similar to https://github.com/facebook/rocksdb/pull/11288 but for user read such as `Get(), MultiGet(), DBIterator::XXX(), Verify(File)Checksum()`.
- For this, I refactored some user-facing `MultiGet` calls in `TransactionBase` and various types of `DB` so that it does not call a user-facing `Get()` but `GetImpl()` for passing the `ReadOptions::io_activity` check (see PR conversation)
- New user read stats breakdown are guarded by `kExceptDetailedTimers` since measurement shows they have 4-5% regression to the upstream/main.
- Misc
- More refactoring: with https://github.com/facebook/rocksdb/pull/11288, we complete passing `ReadOptions/IOOptions` to FS level. So we can now replace the previously [added](https://github.com/facebook/rocksdb/pull/9424) `rate_limiter_priority` parameter in `RandomAccessFileReader`'s `Read/MultiRead/Prefetch()` with `IOOptions::rate_limiter_priority`
- Also, `ReadAsync()` call time is measured in `SST_READ_MICRO` now
Pull Request resolved: https://github.com/facebook/rocksdb/pull/11444
Test Plan:
- CI fake db crash/stress test
- Microbenchmarking
**Build** `make clean && ROCKSDB_NO_FBCODE=1 DEBUG_LEVEL=0 make -jN db_basic_bench`
- google benchmark version: 604f6fd3f4
- db_basic_bench_base: upstream
- db_basic_bench_pr: db_basic_bench_base + this PR
- asyncread_db_basic_bench_base: upstream + [db basic bench patch for IteratorNext](https://github.com/facebook/rocksdb/compare/main...hx235:rocksdb:micro_bench_async_read)
- asyncread_db_basic_bench_pr: asyncread_db_basic_bench_base + this PR
**Test**
Get
```
TEST_TMPDIR=/dev/shm ./db_basic_bench_{null_stat|base|pr} --benchmark_filter=DBGet/comp_style:0/max_data:134217728/per_key_size:256/enable_statistics:1/negative_query:0/enable_filter:0/mmap:1/threads:1 --benchmark_repetitions=1000
```
Result
```
Coming soon
```
AsyncRead
```
TEST_TMPDIR=/dev/shm ./asyncread_db_basic_bench_{base|pr} --benchmark_filter=IteratorNext/comp_style:0/max_data:134217728/per_key_size:256/enable_statistics:1/async_io:1/include_detailed_timers:0 --benchmark_repetitions=1000 > syncread_db_basic_bench_{base|pr}.out
```
Result
```
Base:
1956,1956,1968,1977,1979,1986,1988,1988,1988,1990,1991,1991,1993,1993,1993,1993,1994,1996,1997,1997,1997,1998,1999,2001,2001,2002,2004,2007,2007,2008,
PR (2.3% regression, due to measuring `SST_READ_MICRO` that wasn't measured before):
1993,2014,2016,2022,2024,2027,2027,2028,2028,2030,2031,2031,2032,2032,2038,2039,2042,2044,2044,2047,2047,2047,2048,2049,2050,2052,2052,2052,2053,2053,
```
Reviewed By: ajkr
Differential Revision: D45918925
Pulled By: hx235
fbshipit-source-id: 58a54560d9ebeb3a59b6d807639692614dad058a
159 lines
6.1 KiB
C++
159 lines
6.1 KiB
C++
// Copyright (c) 2011-present, Facebook, Inc. All rights reserved.
|
|
// This source code is licensed under both the GPLv2 (found in the
|
|
// COPYING file in the root directory) and Apache 2.0 License
|
|
// (found in the LICENSE.Apache file in the root directory).
|
|
|
|
#pragma once
|
|
#include <string>
|
|
#include <vector>
|
|
|
|
#include "db/db_impl/db_impl.h"
|
|
|
|
namespace ROCKSDB_NAMESPACE {
|
|
|
|
// TODO: Share common structure with DBImplSecondary and DBImplReadOnly
|
|
class CompactedDBImpl : public DBImpl {
|
|
public:
|
|
CompactedDBImpl(const DBOptions& options, const std::string& dbname);
|
|
// No copying allowed
|
|
CompactedDBImpl(const CompactedDBImpl&) = delete;
|
|
void operator=(const CompactedDBImpl&) = delete;
|
|
|
|
~CompactedDBImpl() override;
|
|
|
|
static Status Open(const Options& options, const std::string& dbname,
|
|
DB** dbptr);
|
|
|
|
// Implementations of the DB interface
|
|
using DB::Get;
|
|
virtual Status Get(const ReadOptions& options,
|
|
ColumnFamilyHandle* column_family, const Slice& key,
|
|
PinnableSlice* value) override;
|
|
|
|
Status Get(const ReadOptions& _read_options,
|
|
ColumnFamilyHandle* column_family, const Slice& key,
|
|
PinnableSlice* value, std::string* timestamp) override;
|
|
|
|
using DB::MultiGet;
|
|
// Note that CompactedDBImpl::MultiGet is not the optimized version of
|
|
// MultiGet to use.
|
|
// TODO: optimize CompactedDBImpl::MultiGet, see DBImpl::MultiGet for details.
|
|
virtual std::vector<Status> MultiGet(
|
|
const ReadOptions& options, const std::vector<ColumnFamilyHandle*>&,
|
|
const std::vector<Slice>& keys,
|
|
std::vector<std::string>* values) override;
|
|
|
|
std::vector<Status> MultiGet(const ReadOptions& _read_options,
|
|
const std::vector<ColumnFamilyHandle*>&,
|
|
const std::vector<Slice>& keys,
|
|
std::vector<std::string>* values,
|
|
std::vector<std::string>* timestamps) override;
|
|
|
|
using DBImpl::Put;
|
|
virtual Status Put(const WriteOptions& /*options*/,
|
|
ColumnFamilyHandle* /*column_family*/,
|
|
const Slice& /*key*/, const Slice& /*value*/) override {
|
|
return Status::NotSupported("Not supported in compacted db mode.");
|
|
}
|
|
|
|
using DBImpl::PutEntity;
|
|
Status PutEntity(const WriteOptions& /* options */,
|
|
ColumnFamilyHandle* /* column_family */,
|
|
const Slice& /* key */,
|
|
const WideColumns& /* columns */) override {
|
|
return Status::NotSupported("Not supported in compacted db mode.");
|
|
}
|
|
|
|
using DBImpl::Merge;
|
|
virtual Status Merge(const WriteOptions& /*options*/,
|
|
ColumnFamilyHandle* /*column_family*/,
|
|
const Slice& /*key*/, const Slice& /*value*/) override {
|
|
return Status::NotSupported("Not supported in compacted db mode.");
|
|
}
|
|
|
|
using DBImpl::Delete;
|
|
virtual Status Delete(const WriteOptions& /*options*/,
|
|
ColumnFamilyHandle* /*column_family*/,
|
|
const Slice& /*key*/) override {
|
|
return Status::NotSupported("Not supported in compacted db mode.");
|
|
}
|
|
virtual Status Write(const WriteOptions& /*options*/,
|
|
WriteBatch* /*updates*/) override {
|
|
return Status::NotSupported("Not supported in compacted db mode.");
|
|
}
|
|
using DBImpl::CompactRange;
|
|
virtual Status CompactRange(const CompactRangeOptions& /*options*/,
|
|
ColumnFamilyHandle* /*column_family*/,
|
|
const Slice* /*begin*/,
|
|
const Slice* /*end*/) override {
|
|
return Status::NotSupported("Not supported in compacted db mode.");
|
|
}
|
|
|
|
virtual Status DisableFileDeletions() override {
|
|
return Status::NotSupported("Not supported in compacted db mode.");
|
|
}
|
|
virtual Status EnableFileDeletions(bool /*force*/) override {
|
|
return Status::NotSupported("Not supported in compacted db mode.");
|
|
}
|
|
virtual Status GetLiveFiles(std::vector<std::string>& ret,
|
|
uint64_t* manifest_file_size,
|
|
bool /*flush_memtable*/) override {
|
|
return DBImpl::GetLiveFiles(ret, manifest_file_size,
|
|
false /* flush_memtable */);
|
|
}
|
|
using DBImpl::Flush;
|
|
virtual Status Flush(const FlushOptions& /*options*/,
|
|
ColumnFamilyHandle* /*column_family*/) override {
|
|
return Status::NotSupported("Not supported in compacted db mode.");
|
|
}
|
|
|
|
virtual Status SyncWAL() override {
|
|
return Status::NotSupported("Not supported in compacted db mode.");
|
|
}
|
|
|
|
using DB::IngestExternalFile;
|
|
virtual Status IngestExternalFile(
|
|
ColumnFamilyHandle* /*column_family*/,
|
|
const std::vector<std::string>& /*external_files*/,
|
|
const IngestExternalFileOptions& /*ingestion_options*/) override {
|
|
return Status::NotSupported("Not supported in compacted db mode.");
|
|
}
|
|
|
|
using DB::CreateColumnFamilyWithImport;
|
|
virtual Status CreateColumnFamilyWithImport(
|
|
const ColumnFamilyOptions& /*options*/,
|
|
const std::string& /*column_family_name*/,
|
|
const ImportColumnFamilyOptions& /*import_options*/,
|
|
const std::vector<const ExportImportFilesMetaData*>& /*metadatas*/,
|
|
ColumnFamilyHandle** /*handle*/) override {
|
|
return Status::NotSupported("Not supported in compacted db mode.");
|
|
}
|
|
|
|
using DB::ClipColumnFamily;
|
|
virtual Status ClipColumnFamily(ColumnFamilyHandle* /*column_family*/,
|
|
const Slice& /*begin*/,
|
|
const Slice& /*end*/) override {
|
|
return Status::NotSupported("Not supported in compacted db mode.");
|
|
}
|
|
|
|
// FIXME: some missing overrides for more "write" functions
|
|
// Share with DBImplReadOnly?
|
|
|
|
protected:
|
|
Status FlushForGetLiveFiles() override {
|
|
// No-op for read-only DB
|
|
return Status::OK();
|
|
}
|
|
|
|
private:
|
|
friend class DB;
|
|
inline size_t FindFile(const Slice& key);
|
|
Status Init(const Options& options);
|
|
|
|
ColumnFamilyData* cfd_;
|
|
Version* version_;
|
|
const Comparator* user_comparator_;
|
|
LevelFilesBrief files_;
|
|
};
|
|
} // namespace ROCKSDB_NAMESPACE
|