mirror of
https://github.com/facebook/rocksdb.git
synced 2024-11-27 11:43:49 +00:00
fe56cb9aa0
Summary: Historically, `BlobFileReader` has returned the blob(s) read from the file in the `PinnableSlice` provided by the client. This interface was preserved when caching was implemented for blobs, which meant that the blob data was copied multiple times when caching was in use: first, into the client-provided `PinnableSlice` (by `BlobFileReader::SaveValue`), and then, into the object stored in the cache (by `BlobSource::PutBlobIntoCache`). The patch eliminates these copies and the related allocations by changing `BlobFileReader` so it returns its results in the form of heap-allocated `BlobContents` objects that can be directly inserted into the cache. The allocations backing these `BlobContents` objects are made using the blob cache's allocator if the blobs are to be inserted into the cache (i.e. if a cache is configured and the `fill_cache` read option is set). Note: this PR focuses on the common case when blobs are compressed; some further small optimizations are possible for uncompressed blobs. Pull Request resolved: https://github.com/facebook/rocksdb/pull/10647 Test Plan: `make check` Reviewed By: riversand963 Differential Revision: D39335185 Pulled By: ltamasi fbshipit-source-id: 464503d60a5520d654c8273ffb8efd5d1bcd7b36 |
||
|---|---|---|
| .. | ||
| blob_constants.h | ||
| blob_contents.cc | ||
| blob_contents.h | ||
| blob_counting_iterator.h | ||
| blob_counting_iterator_test.cc | ||
| blob_fetcher.cc | ||
| blob_fetcher.h | ||
| blob_file_addition.cc | ||
| blob_file_addition.h | ||
| blob_file_addition_test.cc | ||
| blob_file_builder.cc | ||
| blob_file_builder.h | ||
| blob_file_builder_test.cc | ||
| blob_file_cache.cc | ||
| blob_file_cache.h | ||
| blob_file_cache_test.cc | ||
| blob_file_completion_callback.h | ||
| blob_file_garbage.cc | ||
| blob_file_garbage.h | ||
| blob_file_garbage_test.cc | ||
| blob_file_meta.cc | ||
| blob_file_meta.h | ||
| blob_file_reader.cc | ||
| blob_file_reader.h | ||
| blob_file_reader_test.cc | ||
| blob_garbage_meter.cc | ||
| blob_garbage_meter.h | ||
| blob_garbage_meter_test.cc | ||
| blob_index.h | ||
| blob_log_format.cc | ||
| blob_log_format.h | ||
| blob_log_sequential_reader.cc | ||
| blob_log_sequential_reader.h | ||
| blob_log_writer.cc | ||
| blob_log_writer.h | ||
| blob_read_request.h | ||
| blob_source.cc | ||
| blob_source.h | ||
| blob_source_test.cc | ||
| db_blob_basic_test.cc | ||
| db_blob_compaction_test.cc | ||
| db_blob_corruption_test.cc | ||
| db_blob_index_test.cc | ||
| prefetch_buffer_collection.cc | ||
| prefetch_buffer_collection.h | ||