mirror of
https://github.com/facebook/rocksdb.git
synced 2024-11-26 16:30:56 +00:00
9167ece586
Summary: This is a duplicate of https://github.com/facebook/rocksdb/issues/4948 by mzhaom to fix tests after rebase. This change is a follow-up to https://github.com/facebook/rocksdb/issues/4927, which made this possible by allowing tombstone dropping/seqnum zeroing optimizations on the last key in the compaction. Now the `largest_seqno != 0` condition suffices to prevent snapshot release triggered compaction from entering an infinite loop. The issues caused by the extraneous condition `level_and_file.second->num_deletions > 1` are: - files could have `largest_seqno > 0` forever making it impossible to tell they cannot contain any covering keys - it doesn't trigger compaction when there are many overwritten keys. Some MyRocks use case actually doesn't use Delete but instead calls Put with empty value to "delete" keys, so we'd like to be able to trigger compaction in this case too. Pull Request resolved: https://github.com/facebook/rocksdb/pull/8357 Test Plan: - make check Reviewed By: jay-zhuang Differential Revision: D28855340 Pulled By: ajkr fbshipit-source-id: a261b51eecafec492499e6d01e8e43112f801798 |
||
|---|---|---|
| .. | ||
| blob_compaction_filter.cc | ||
| blob_compaction_filter.h | ||
| blob_db.cc | ||
| blob_db.h | ||
| blob_db_gc_stats.h | ||
| blob_db_impl.cc | ||
| blob_db_impl.h | ||
| blob_db_impl_filesnapshot.cc | ||
| blob_db_iterator.h | ||
| blob_db_listener.h | ||
| blob_db_test.cc | ||
| blob_dump_tool.cc | ||
| blob_dump_tool.h | ||
| blob_file.cc | ||
| blob_file.h | ||