Peter Dillinger e92a0ed040 Optimize & clean up footer code (#9280) ... Summary: Again, ahead of planned changes in https://github.com/facebook/rocksdb/issues/9058. This change improves performance (vs. pre-https://github.com/facebook/rocksdb/issues/9240 baseline) by separating a FooterBuilder from Footer, where FooterBuilder includes (inline owns) the serialized data so that it can be stack allocated. Pull Request resolved: https://github.com/facebook/rocksdb/pull/9280 Test Plan: existing tests + performance testing below Extreme case performance testing as in https://github.com/facebook/rocksdb/issues/9240 with TEST_TMPDIR=/dev/shm/ ./db_bench -benchmarks=fillseq -memtablerep=vector -allow_concurrent_memtable_write=false -num=30000000 (Each is ops/s averaged over 50 runs, run simultaneously with competing configuration for load fairness) Pre-https://github.com/facebook/rocksdb/issues/9240 baseline (f577458): 436389 With https://github.com/facebook/rocksdb/issues/9240 (653c392): 417946 (-4.2% vs. baseline) This change: 443762 (+1.7% vs. baseline) Reviewed By: ajkr Differential Revision: D33077220 Pulled By: pdillinger fbshipit-source-id: 7eaa6499589aac1693414a758e8c799216c5016c		2021-12-13 17:43:07 -08:00
..
adaptive	More refactoring ahead of footer & meta changes (#9240)	2021-12-10 08:13:26 -08:00
block_based	Optimize & clean up footer code (#9280)	2021-12-13 17:43:07 -08:00
cuckoo	Optimize & clean up footer code (#9280)	2021-12-13 17:43:07 -08:00
plain	Optimize & clean up footer code (#9280)	2021-12-13 17:43:07 -08:00
block_fetcher.cc	More refactoring ahead of footer & meta changes (#9240)	2021-12-10 08:13:26 -08:00
block_fetcher.h	More refactoring ahead of footer & meta changes (#9240)	2021-12-10 08:13:26 -08:00
block_fetcher_test.cc	Cleanup includes in dbformat.h (#8930)	2021-09-29 04:04:40 -07:00
cleanable_test.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	2020-02-20 12:09:57 -08:00
format.cc	Optimize & clean up footer code (#9280)	2021-12-13 17:43:07 -08:00
format.h	Optimize & clean up footer code (#9280)	2021-12-13 17:43:07 -08:00
get_context.cc	Support readahead during compaction for blob files (#9187)	2021-11-19 17:53:47 -08:00
get_context.h	Cleanup includes in dbformat.h (#8930)	2021-09-29 04:04:40 -07:00
internal_iterator.h	Reuse internal auto readhead_size at each Level (expect L0) for Iterations (#9056)	2021-11-10 16:20:04 -08:00
iter_heap.h	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	2020-02-20 12:09:57 -08:00
iterator.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	2020-02-20 12:09:57 -08:00
iterator_wrapper.h	Reuse internal auto readhead_size at each Level (expect L0) for Iterations (#9056)	2021-11-10 16:20:04 -08:00
merger_test.cc	Cleanup multiple implementations of VectorIterator (#8901)	2021-10-06 07:48:31 -07:00
merging_iterator.cc	MergingIterator: rearrange fields to reduce paddings (#9024)	2021-10-14 12:01:56 -07:00
merging_iterator.h	Cleanup includes in dbformat.h (#8930)	2021-09-29 04:04:40 -07:00
meta_blocks.cc	More refactoring ahead of footer & meta changes (#9240)	2021-12-10 08:13:26 -08:00
meta_blocks.h	More refactoring ahead of footer & meta changes (#9240)	2021-12-10 08:13:26 -08:00
mock_table.cc	Introduce a mechanism to dump out blocks from block cache and re-insert to secondary cache (#8912)	2021-10-07 11:42:31 -07:00
mock_table.h	Fix some minor issues in the Customizable infrastructure (#8566)	2021-08-19 10:10:47 -07:00
multiget_context.h	Batch blob read IO for MultiGet (#8699)	2021-09-17 19:23:13 -07:00
persistent_cache_helper.cc	Improve / clean up meta block code & integrity (#9163)	2021-11-18 11:43:44 -08:00
persistent_cache_helper.h	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	2020-02-20 12:09:57 -08:00
persistent_cache_options.h	Improve / clean up meta block code & integrity (#9163)	2021-11-18 11:43:44 -08:00
scoped_arena_iterator.h	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	2020-02-20 12:09:57 -08:00
sst_file_dumper.cc	More refactoring ahead of footer & meta changes (#9240)	2021-12-10 08:13:26 -08:00
sst_file_dumper.h	Make ImmutableOptions struct that inherits from ImmutableCFOptions and ImmutableDBOptions (#8262)	2021-05-05 14:00:17 -07:00
sst_file_reader.cc	Make ImmutableOptions struct that inherits from ImmutableCFOptions and ImmutableDBOptions (#8262)	2021-05-05 14:00:17 -07:00
sst_file_reader_test.cc	Enable a few unit tests to use custom Env objects (#9087)	2021-11-08 11:05:59 -08:00
sst_file_writer.cc	Support timestamps in SstFileWriter (#8899)	2021-09-09 18:58:01 -07:00
sst_file_writer_collectors.h	Cleanup includes in dbformat.h (#8930)	2021-09-29 04:04:40 -07:00
table_builder.h	Partially revert the "apply subrange of table property collectors" change (#8465)	2021-07-06 10:14:32 -07:00
table_factory.cc	Add customizable_util.h to the public API (#8301)	2021-06-29 09:08:57 -07:00
table_properties.cc	Improve / clean up meta block code & integrity (#9163)	2021-11-18 11:43:44 -08:00
table_properties_internal.h	Improve / clean up meta block code & integrity (#9163)	2021-11-18 11:43:44 -08:00
table_reader.h	dedup ReadOptions in iterator hierarchy (#7210)	2020-08-03 15:23:04 -07:00
table_reader_bench.cc	Make it possible to apply only a subrange of table property collectors (#8298)	2021-05-17 18:28:39 -07:00
table_reader_caller.h	Fix and detect headers with missing dependencies (#8893)	2021-09-10 10:00:26 -07:00
table_test.cc	Optimize & clean up footer code (#9280)	2021-12-13 17:43:07 -08:00
two_level_iterator.cc	Clarify caching behavior for index and filter partitions (#9068)	2021-10-27 17:23:04 -07:00
two_level_iterator.h	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	2020-02-20 12:09:57 -08:00
unique_id.cc	Experimental support for SST unique IDs (#8990)	2021-10-18 23:32:01 -07:00
unique_id_impl.h	Experimental support for SST unique IDs (#8990)	2021-10-18 23:32:01 -07:00