mirror of https://github.com/facebook/rocksdb.git
beb86addeb
Summary: There is a race in SstFileManagerImpl between the ClearError() function and CancelErrorRecovery(). The race can cause ClearError() to deref the file system pointer after it has been freed. This is likely to occur during process shutdown, when the order of destruction of the DB/Env/FileSystem and SstFileManagerImpl is not deterministic. Pull Request resolved: https://github.com/facebook/rocksdb/pull/9435 Test Plan: Reproduce the crash in a TSAN build by introducing sleeps in the code, and verify with the fix. Reviewed By: siying Differential Revision: D33774696 Pulled By: anand1976 fbshipit-source-id: 643d3da31b8d2ee6d9b6db5d33327e0053ce3b83 |
||
|---|---|---|
| .. | ||
| delete_scheduler.cc | ||
| delete_scheduler.h | ||
| delete_scheduler_test.cc | ||
| file_prefetch_buffer.cc | ||
| file_prefetch_buffer.h | ||
| file_util.cc | ||
| file_util.h | ||
| filename.cc | ||
| filename.h | ||
| line_file_reader.cc | ||
| line_file_reader.h | ||
| prefetch_test.cc | ||
| random_access_file_reader.cc | ||
| random_access_file_reader.h | ||
| random_access_file_reader_test.cc | ||
| read_write_util.cc | ||
| read_write_util.h | ||
| readahead_file_info.h | ||
| readahead_raf.cc | ||
| readahead_raf.h | ||
| sequence_file_reader.cc | ||
| sequence_file_reader.h | ||
| sst_file_manager_impl.cc | ||
| sst_file_manager_impl.h | ||
| writable_file_writer.cc | ||
| writable_file_writer.h | ||