mirror of
https://github.com/facebook/rocksdb.git
synced 2024-11-29 18:33:58 +00:00
5234fc1b70
Summary: In prepare phase of 2PC, the db promises to remember the prepared data, for possible future commits. To fulfill the promise the prepared data must be persisted in the WAL so that they could be recovered after a crash. The log that contains a prepare batch that is not committed yet, is marked so that it is not garbage collected before the transaction commits/rollbacks. The bug was that the write to the log file and the mark of the file was not atomic, and WAL gc could have happened before the WAL log is actually marked. This patch moves the marking logic to PreReleaseCallback so that the WAL gc logic that joins both write threads would see the WAL write and WAL mark atomically. Pull Request resolved: https://github.com/facebook/rocksdb/pull/5121 Differential Revision: D14665210 Pulled By: maysamyabandeh fbshipit-source-id: 1d66aeb1c66a296cb4899a5a20c4d40c59e4b534
35 lines
1.3 KiB
C++
35 lines
1.3 KiB
C++
// Copyright (c) 2011-present, Facebook, Inc. All rights reserved.
|
|
// This source code is licensed under both the GPLv2 (found in the
|
|
// COPYING file in the root directory) and Apache 2.0 License
|
|
// (found in the LICENSE.Apache file in the root directory).
|
|
|
|
#pragma once
|
|
|
|
#include "rocksdb/status.h"
|
|
|
|
namespace rocksdb {
|
|
|
|
class DB;
|
|
|
|
class PreReleaseCallback {
|
|
public:
|
|
virtual ~PreReleaseCallback() {}
|
|
|
|
// Will be called while on the write thread after the write to the WAL and
|
|
// before the write to memtable. This is useful if any operation needs to be
|
|
// done before the write gets visible to the readers, or if we want to reduce
|
|
// the overhead of locking by updating something sequentially while we are on
|
|
// the write thread. If the callback fails, this function returns a non-OK
|
|
// status, the sequence number will not be released, and same status will be
|
|
// propagated to all the writers in the write group.
|
|
// seq is the sequence number that is used for this write and will be
|
|
// released.
|
|
// is_mem_disabled is currently used for debugging purposes to assert that
|
|
// the callback is done from the right write queue.
|
|
// If non-zero, log_number indicates the WAL log to which we wrote.
|
|
virtual Status Callback(SequenceNumber seq, bool is_mem_disabled,
|
|
uint64_t log_number) = 0;
|
|
};
|
|
|
|
} // namespace rocksdb
|