anand76 0ae3d9f98d Fix stale memory access with FSBuffer and tiered sec cache (#12712) ... Summary: A `BlockBasedTable` with `TieredSecondaryCache` containing a NVM cache inserts blocks into the compressed cache and the corresponding compressed block into the NVM cache. The `BlockFetcher` is used to get the uncompressed and compressed blocks by calling `ReadBlockContents()` and `GetUncompressedBlock()` respectively. If the file system supports FSBuffer (i.e returning a FS allocated buffer rather than caller provided), that buffer gets freed between the two calls. This PR fixes it by making the FSBuffer unique pointer a member rather than local variable. Pull Request resolved: https://github.com/facebook/rocksdb/pull/12712 Test Plan: 1. Add a unit test 2. Release validation stress test Reviewed By: jaykorean Differential Revision: D57974026 Pulled By: anand1976 fbshipit-source-id: cfa895914e74b4f628413b40e6e39d8d8e5286bd		2024-05-30 12:33:58 -07:00
..
adaptive	Remove unnecessary, confusing 'extern' (#12300)	2024-01-29 10:38:08 -08:00
block_based	Lazily construct BlockBasedTableIterator::block_handles_ (#12616)	2024-05-03 17:18:13 -07:00
cuckoo	Fix kBlockCacheTier read when merge-chain base value is in a blob file (#12462)	2024-03-21 12:38:53 -07:00
plain	Fix kBlockCacheTier read when merge-chain base value is in a blob file (#12462)	2024-03-21 12:38:53 -07:00
block_fetcher.cc	Fix stale memory access with FSBuffer and tiered sec cache (#12712)	2024-05-30 12:33:58 -07:00
block_fetcher.h	Fix stale memory access with FSBuffer and tiered sec cache (#12712)	2024-05-30 12:33:58 -07:00
block_fetcher_test.cc	Use format_version=6 by default (#12352)	2024-02-15 11:23:48 -08:00
cleanable_test.cc	Eliminate unnecessary (slow) block cache Ref()ing in MultiGet (#9899)	2022-04-26 21:59:24 -07:00
compaction_merging_iterator.cc	Fix a bug where iterator status is not checked (#11782)	2023-09-01 09:34:08 -07:00
compaction_merging_iterator.h	Refactor AddRangeDels() + consider range tombstone during compaction file cutting (#11113)	2023-02-22 12:28:18 -08:00
format.cc	Remove unnecessary, confusing 'extern' (#12300)	2024-01-29 10:38:08 -08:00
format.h	Remove unnecessary, confusing 'extern' (#12300)	2024-01-29 10:38:08 -08:00
get_context.cc	Fix kBlockCacheTier read when merge-chain base value is in a blob file (#12462)	2024-03-21 12:38:53 -07:00
get_context.h	Fix kBlockCacheTier read when merge-chain base value is in a blob file (#12462)	2024-03-21 12:38:53 -07:00
internal_iterator.h	Support returning write unix time in iterator property (#12428)	2024-03-15 15:37:37 -07:00
iter_heap.h	Format files under table/ by clang-format (#10852)	2022-10-25 11:50:38 -07:00
iterator.cc	Add Iterator property "rocksdb.iterator.is-value-pinned" (#12659)	2024-05-15 19:11:52 -07:00
iterator_wrapper.h	Support returning write unix time in iterator property (#12428)	2024-03-15 15:37:37 -07:00
merger_test.cc	internal_repo_rocksdb (435146444452818992) (#12115)	2023-12-01 11:15:17 -08:00
merging_iterator.cc	Support returning write unix time in iterator property (#12428)	2024-03-15 15:37:37 -07:00
merging_iterator.h	Remove unnecessary, confusing 'extern' (#12300)	2024-01-29 10:38:08 -08:00
meta_blocks.cc	Rename IntTblPropCollector -> InternalTblPropColl (#12320)	2024-02-02 14:14:43 -08:00
meta_blocks.h	Rename IntTblPropCollector -> InternalTblPropColl (#12320)	2024-02-02 14:14:43 -08:00
mock_table.cc	Fix kBlockCacheTier read when merge-chain base value is in a blob file (#12462)	2024-03-21 12:38:53 -07:00
mock_table.h	Remove 'virtual' when implied by 'override' (#12319)	2024-01-31 13:14:42 -08:00
multiget_context.h	Add a new MultiGetEntity API (#11222)	2023-02-15 09:34:17 -08:00
persistent_cache_helper.cc	Remove extra semi colon from internal_repo_rocksdb/repo/db/table_cache_sync_and_async.h	2024-03-04 06:34:44 -08:00
persistent_cache_helper.h	Change internal headers with duplicate names (#11408)	2023-05-17 11:27:09 -07:00
persistent_cache_options.h	Change internal headers with duplicate names (#11408)	2023-05-17 11:27:09 -07:00
sst_file_dumper.cc	Support read timestamp in ldb (#12641)	2024-05-13 15:43:12 -07:00
sst_file_dumper.h	Augment sst_dump tool to verify num_entries in table property (#12322)	2024-02-01 14:35:03 -08:00
sst_file_reader.cc	Remove extra semi colon from internal_repo_rocksdb/repo/table/sst_file_reader.cc	2024-05-22 07:14:52 -07:00
sst_file_reader_test.cc	Add support in SstFileReader to get a raw table iterator (#12385)	2024-04-02 21:23:06 -07:00
sst_file_writer.cc	Fix/improve temperature handling for file ingestion (#12402)	2024-03-05 16:56:08 -08:00
sst_file_writer_collectors.h	Rename IntTblPropCollector -> InternalTblPropColl (#12320)	2024-02-02 14:14:43 -08:00
table_builder.h	Remove extra semi colon from internal_repo_rocksdb/repo/db/table_cache_sync_and_async.h	2024-03-04 06:34:44 -08:00
table_factory.cc	Remove FactoryFunc from LoadXXXObject (#11203)	2023-02-17 12:54:07 -08:00
table_iterator.h	Add support in SstFileReader to get a raw table iterator (#12385)	2024-04-02 21:23:06 -07:00
table_properties.cc	Fix/cleanup SeqnoToTimeMapping (#12253)	2024-01-19 21:50:38 -08:00
table_properties_internal.h	Improve / clean up meta block code & integrity (#9163)	2021-11-18 11:43:44 -08:00
table_reader.h	Add new Iterator API Refresh(const snapshot*) (#10594)	2023-09-15 10:44:43 -07:00
table_reader_bench.cc	Rename IntTblPropCollector -> InternalTblPropColl (#12320)	2024-02-02 14:14:43 -08:00
table_test.cc	Fix wrong padded bytes being used to generate file checksum (#12598)	2024-04-30 15:38:53 -07:00
two_level_iterator.cc	internal_repo_rocksdb (435146444452818992) (#12115)	2023-12-01 11:15:17 -08:00
two_level_iterator.h	Remove unnecessary, confusing 'extern' (#12300)	2024-01-29 10:38:08 -08:00
unique_id.cc	internal_repo_rocksdb (435146444452818992) (#12115)	2023-12-01 11:15:17 -08:00
unique_id_impl.h	Derive cache keys from SST unique IDs (#10394)	2022-08-12 13:49:49 -07:00