mirror of https://github.com/facebook/rocksdb.git
6acbbbf9fc
Summary: Add Github Action to perform some basic sanity check for PR, inclding the following. 1) Buck TARGETS file. On the one hand, The TARGETS file is used for internal buck, and we do not manually update it. On the other hand, we need to run the buckifier scripts to update TARGETS whenever new files are added, etc. With this Github Action, we make sure that every PR does not forget this step. The GH Action uses a Makefile target called check-buck-targets. Users can manually run `make check-buck-targets` on local machine. 2) Code format We use clang-format-diff.py to format our code. The GH Action in this PR makes sure this step is not skipped. The checking script build_tools/format-diff.sh assumes that `clang-format-diff.py` is executable. On host running GH Action, it is difficult to download `clang-format-diff.py` and make it executable. Therefore, we modified build_tools/format-diff.sh to handle the case in which there is a non-executable clang-format-diff.py file in the top-level rocksdb repo directory. Test Plan (Github and devserver): Watch for Github Action result in the `Checks` tab. On dev server ``` make check-format make check-buck-targets make check ``` Pull Request resolved: https://github.com/facebook/rocksdb/pull/6761 Test Plan: Watch for Github Action result in the `Checks` tab. Reviewed By: pdillinger Differential Revision: D21260209 Pulled By: riversand963 fbshipit-source-id: c646e2f37c6faf9f0614b68aa0efc818cff96787 |
||
|---|---|---|
| .. | ||
| amalgamate.py | ||
| build_detect_platform | ||
| dependencies.sh | ||
| dependencies_4.8.1.sh | ||
| dependencies_platform007.sh | ||
| dockerbuild.sh | ||
| error_filter.py | ||
| fb_compile_mongo.sh | ||
| fbcode_config.sh | ||
| fbcode_config4.8.1.sh | ||
| fbcode_config_platform007.sh | ||
| format-diff.sh | ||
| gnu_parallel | ||
| make_package.sh | ||
| precommit_checker.py | ||
| regression_build_test.sh | ||
| rocksdb-lego-determinator | ||
| run_ci_db_test.ps1 | ||
| setup_centos7.sh | ||
| update_dependencies.sh | ||
| version.sh | ||