mirror of
https://github.com/facebook/rocksdb.git
synced 2024-11-26 07:30:54 +00:00
1d6dbfb8b7
Summary: I've always found this name difficult to read, because it sounds like it's for collecting int(eger) table properties. I'm fixing this now to set up for a change that I have stubbed out in the public API (table_properties.h): a new adapter function `TablePropertiesCollector::AsInternal()` that allows RocksDB-provided TablePropertiesCollectors (such as CompactOnDeletionCollector) to implement the easier-to-upgrade internal interface while still (superficially) implementing the public interface. In addition to added flexibility, this should be a performance improvement as the adapter class UserKeyTablePropertiesCollector can be avoided for such cases where a RocksDB-provided collector is used (AsInternal() returns non-nullptr). table_properties.h is the only file with changes that aren't simple find-replace renaming. Pull Request resolved: https://github.com/facebook/rocksdb/pull/12320 Test Plan: existing tests, CI Reviewed By: ajkr Differential Revision: D53336945 Pulled By: pdillinger fbshipit-source-id: 02535bcb30bbfb00e29e8478af62e5dad50a63b8 |
||
|---|---|---|
| .. | ||
| plain_table_bloom.cc | ||
| plain_table_bloom.h | ||
| plain_table_builder.cc | ||
| plain_table_builder.h | ||
| plain_table_factory.cc | ||
| plain_table_factory.h | ||
| plain_table_index.cc | ||
| plain_table_index.h | ||
| plain_table_key_coding.cc | ||
| plain_table_key_coding.h | ||
| plain_table_reader.cc | ||
| plain_table_reader.h | ||