mirror of
https://github.com/facebook/rocksdb.git
synced 2024-11-30 04:41:49 +00:00
787229837e
Summary:
On MacOS, there were errors building in LITE mode related to unused private member variables:
In file included from ./db/compaction/compaction_job.h:20:
./db/blob/blob_file_completion_callback.h:87:19: error: private field ‘sst_file_manager_’ is not used [-Werror,-Wunused-private-field]
SstFileManager* sst_file_manager_;
^
./db/blob/blob_file_completion_callback.h:88:22: error: private field ‘mutex_’ is not used [-Werror,-Wunused-private-field]
InstrumentedMutex* mutex_;
^
./db/blob/blob_file_completion_callback.h:89:17: error: private field ‘error_handler_’ is not used [-Werror,-Wunused-private-field]
ErrorHandler* error_handler_;
This PR resolves those build issues by removing the values as members in LITE mode and fixing the constructor to ignore the input values in LITE mode (otherwise we get unused parameter warnings).
Tested by validating compiles without warnings.
Pull Request resolved: https://github.com/facebook/rocksdb/pull/8981
Reviewed By: akankshamahajan15
Differential Revision: D31320141
Pulled By: mrambacher
fbshipit-source-id: d67875ebbd39a9555e4f09b2d37159566dd8a085
102 lines
3.7 KiB
C++
102 lines
3.7 KiB
C++
// Copyright (c) 2011-present, Facebook, Inc. All rights reserved.
|
|
// This source code is licensed under both the GPLv2 (found in the
|
|
// COPYING file in the root directory) and Apache 2.0 License
|
|
// (found in the LICENSE.Apache file in the root directory).
|
|
//
|
|
// Copyright (c) 2011 The LevelDB Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file. See the AUTHORS file for names of contributors.
|
|
#pragma once
|
|
|
|
#include "db/error_handler.h"
|
|
#include "db/event_helpers.h"
|
|
#include "file/sst_file_manager_impl.h"
|
|
#include "rocksdb/status.h"
|
|
|
|
namespace ROCKSDB_NAMESPACE {
|
|
|
|
class BlobFileCompletionCallback {
|
|
public:
|
|
BlobFileCompletionCallback(
|
|
SstFileManager* sst_file_manager, InstrumentedMutex* mutex,
|
|
ErrorHandler* error_handler, EventLogger* event_logger,
|
|
const std::vector<std::shared_ptr<EventListener>>& listeners,
|
|
const std::string& dbname)
|
|
: event_logger_(event_logger), listeners_(listeners), dbname_(dbname) {
|
|
#ifndef ROCKSDB_LITE
|
|
sst_file_manager_ = sst_file_manager;
|
|
mutex_ = mutex;
|
|
error_handler_ = error_handler;
|
|
#else
|
|
(void)sst_file_manager;
|
|
(void)mutex;
|
|
(void)error_handler;
|
|
#endif // ROCKSDB_LITE
|
|
}
|
|
|
|
void OnBlobFileCreationStarted(const std::string& file_name,
|
|
const std::string& column_family_name,
|
|
int job_id,
|
|
BlobFileCreationReason creation_reason) {
|
|
#ifndef ROCKSDB_LITE
|
|
// Notify the listeners.
|
|
EventHelpers::NotifyBlobFileCreationStarted(listeners_, dbname_,
|
|
column_family_name, file_name,
|
|
job_id, creation_reason);
|
|
#else
|
|
(void)file_name;
|
|
(void)column_family_name;
|
|
(void)job_id;
|
|
(void)creation_reason;
|
|
#endif
|
|
}
|
|
|
|
Status OnBlobFileCompleted(const std::string& file_name,
|
|
const std::string& column_family_name, int job_id,
|
|
uint64_t file_number,
|
|
BlobFileCreationReason creation_reason,
|
|
const Status& report_status,
|
|
const std::string& checksum_value,
|
|
const std::string& checksum_method,
|
|
uint64_t blob_count, uint64_t blob_bytes) {
|
|
Status s;
|
|
|
|
#ifndef ROCKSDB_LITE
|
|
auto sfm = static_cast<SstFileManagerImpl*>(sst_file_manager_);
|
|
if (sfm) {
|
|
// Report new blob files to SstFileManagerImpl
|
|
s = sfm->OnAddFile(file_name);
|
|
if (sfm->IsMaxAllowedSpaceReached()) {
|
|
s = Status::SpaceLimit("Max allowed space was reached");
|
|
TEST_SYNC_POINT(
|
|
"BlobFileCompletionCallback::CallBack::MaxAllowedSpaceReached");
|
|
InstrumentedMutexLock l(mutex_);
|
|
error_handler_->SetBGError(s, BackgroundErrorReason::kFlush);
|
|
}
|
|
}
|
|
#endif // !ROCKSDB_LITE
|
|
|
|
// Notify the listeners.
|
|
EventHelpers::LogAndNotifyBlobFileCreationFinished(
|
|
event_logger_, listeners_, dbname_, column_family_name, file_name,
|
|
job_id, file_number, creation_reason,
|
|
(!report_status.ok() ? report_status : s),
|
|
(checksum_value.empty() ? kUnknownFileChecksum : checksum_value),
|
|
(checksum_method.empty() ? kUnknownFileChecksumFuncName
|
|
: checksum_method),
|
|
blob_count, blob_bytes);
|
|
return s;
|
|
}
|
|
|
|
private:
|
|
#ifndef ROCKSDB_LITE
|
|
SstFileManager* sst_file_manager_;
|
|
InstrumentedMutex* mutex_;
|
|
ErrorHandler* error_handler_;
|
|
#endif // ROCKSDB_LITE
|
|
EventLogger* event_logger_;
|
|
std::vector<std::shared_ptr<EventListener>> listeners_;
|
|
std::string dbname_;
|
|
};
|
|
} // namespace ROCKSDB_NAMESPACE
|