mirror of
https://github.com/facebook/rocksdb.git
synced 2024-11-28 05:43:50 +00:00
62247ffa3b
Summary: When using latest clang (3.6 or 3.7/trunck) rocksdb is failing with many errors. Almost all of them are missing override errors. This diff adds missing override keyword. No manual changes. Prerequisites: bear and clang 3.5 build with extra tools ```lang=bash % USE_CLANG=1 bear make all # generate a compilation database http://clang.llvm.org/docs/JSONCompilationDatabase.html % clang-modernize -p . -include . -add-override % make format ``` Test Plan: Make sure all tests are passing. ```lang=bash % #Use default fb code clang. % make check ``` Verify less error and no missing override errors. ```lang=bash % # Have trunk clang present in path. % ROCKSDB_NO_FBCODE=1 CC=clang CXX=clang++ make ``` Reviewers: igor, kradhakrishnan, rven, meyering, sdong Reviewed By: sdong Subscribers: dhruba, leveldb Differential Revision: https://reviews.facebook.net/D34077 |
||
|---|---|---|
| .. | ||
| builder.cc | ||
| builder.h | ||
| c.cc | ||
| c_test.c | ||
| column_family.cc | ||
| column_family.h | ||
| column_family_test.cc | ||
| compaction.cc | ||
| compaction.h | ||
| compaction_job.cc | ||
| compaction_job.h | ||
| compaction_job_test.cc | ||
| compaction_picker.cc | ||
| compaction_picker.h | ||
| compaction_picker_test.cc | ||
| comparator_db_test.cc | ||
| corruption_test.cc | ||
| cuckoo_table_db_test.cc | ||
| db_bench.cc | ||
| db_filesnapshot.cc | ||
| db_impl.cc | ||
| db_impl.h | ||
| db_impl_debug.cc | ||
| db_impl_readonly.cc | ||
| db_impl_readonly.h | ||
| db_iter.cc | ||
| db_iter.h | ||
| db_iter_test.cc | ||
| db_test.cc | ||
| dbformat.cc | ||
| dbformat.h | ||
| dbformat_test.cc | ||
| deletefile_test.cc | ||
| fault_injection_test.cc | ||
| file_indexer.cc | ||
| file_indexer.h | ||
| file_indexer_test.cc | ||
| filename.cc | ||
| filename.h | ||
| filename_test.cc | ||
| flush_job.cc | ||
| flush_job.h | ||
| flush_job_test.cc | ||
| flush_scheduler.cc | ||
| flush_scheduler.h | ||
| forward_iterator.cc | ||
| forward_iterator.h | ||
| internal_stats.cc | ||
| internal_stats.h | ||
| job_context.h | ||
| listener_test.cc | ||
| log_and_apply_bench.cc | ||
| log_format.h | ||
| log_reader.cc | ||
| log_reader.h | ||
| log_test.cc | ||
| log_writer.cc | ||
| log_writer.h | ||
| managed_iterator.cc | ||
| managed_iterator.h | ||
| memtable.cc | ||
| memtable.h | ||
| memtable_allocator.cc | ||
| memtable_allocator.h | ||
| memtable_list.cc | ||
| memtable_list.h | ||
| memtablerep_bench.cc | ||
| merge_context.h | ||
| merge_helper.cc | ||
| merge_helper.h | ||
| merge_operator.cc | ||
| merge_test.cc | ||
| perf_context_test.cc | ||
| plain_table_db_test.cc | ||
| prefix_test.cc | ||
| repair.cc | ||
| skiplist.h | ||
| skiplist_test.cc | ||
| snapshot.h | ||
| table_cache.cc | ||
| table_cache.h | ||
| table_properties_collector.cc | ||
| table_properties_collector.h | ||
| table_properties_collector_test.cc | ||
| transaction_log_impl.cc | ||
| transaction_log_impl.h | ||
| version_builder.cc | ||
| version_builder.h | ||
| version_builder_test.cc | ||
| version_edit.cc | ||
| version_edit.h | ||
| version_edit_test.cc | ||
| version_set.cc | ||
| version_set.h | ||
| version_set_test.cc | ||
| wal_manager.cc | ||
| wal_manager.h | ||
| wal_manager_test.cc | ||
| write_batch.cc | ||
| write_batch_internal.h | ||
| write_batch_test.cc | ||
| write_controller.cc | ||
| write_controller.h | ||
| write_controller_test.cc | ||
| write_thread.cc | ||
| write_thread.h | ||
| writebuffer.h | ||