Changyu Bi 5c2a063c49 Clarify usage for options ttl and periodic_compaction_seconds for universal compaction (#11552) ... Summary: this is stacked on https://github.com/facebook/rocksdb/issues/11550 to further clarify usage of these two options for universal compaction. Similar to FIFO, the two options have the same meaning for universal compaction, which can be confusing to use. For example, for universal compaction, dynamically changing the value of `ttl` has no impact on periodic compactions. Users should dynamically change `periodic_compaction_seconds` instead. From feature matrix (https://fburl.com/daiquery/5s647hwh), there are instances where users set `ttl` to non-zero value and `periodic_compaction_seconds` to 0. For backward compatibility reason, instead of deprecating `ttl`, comments are added to mention that `periodic_compaction_seconds` are preferred. In `SanitizeOptions()`, we update the value of `periodic_compaction_seconds` to take into account value of `ttl`. The logic is documented in relevant option comment. Pull Request resolved: https://github.com/facebook/rocksdb/pull/11552 Test Plan: * updated existing unit test `DBTestUniversalCompaction2.PeriodicCompactionDefault` Reviewed By: ajkr Differential Revision: D47381434 Pulled By: cbi42 fbshipit-source-id: bc41f29f77318bae9a96be84dd89bf5617c7fd57		2023-07-26 11:31:54 -07:00
..
.gitkeep	Better management of unreleased HISTORY (#11481)	2023-05-30 16:42:49 -07:00
fifo_ttl_periodic_compaction.md	Deprecate option periodic_compaction_seconds for FIFO compaction (#11550)	2023-07-05 14:40:45 -07:00
fs_prefetch_compaction_read.md	Move prefetching responsibility to page cache for compaction read under non directIO usecase (#11631)	2023-07-21 14:52:52 -07:00
universal_ttl_periodic_compaction.md	Clarify usage for options ttl and periodic_compaction_seconds for universal compaction (#11552)	2023-07-26 11:31:54 -07:00