mirror of
https://github.com/facebook/rocksdb.git
synced 2024-11-30 22:41:48 +00:00
3cacd4b4ec
Summary: The definition of the Cache class should not be needed by the vast majority of RocksDB users, so I think it is just distracting to include it in cache.h, which is primarily needed for configuring and creating caches. This change moves the class to a new header advanced_cache.h. It is just cut-and-paste except for modifying the class API comment. In general, operations on shared_ptr<Cache> should continue to work when only a forward declaration of Cache is available, as long as all the Cache instances provided are already shared_ptr. See https://stackoverflow.com/a/17650101/454544 Also, the most common way to customize a Cache is by wrapping an existing implementation, so it makes sense to provide CacheWrapper in the public API. This was a cut-and-paste job except removing the implementation of Name() so that derived classes must provide it. Intended follow-up: consolidate Release() into one function to reduce customization bugs / confusion Pull Request resolved: https://github.com/facebook/rocksdb/pull/11192 Test Plan: `make check` Reviewed By: anand1976 Differential Revision: D43055487 Pulled By: pdillinger fbshipit-source-id: 7b05492df35e0f30b581b4c24c579bc275b6d110
48 lines
1.6 KiB
C++
48 lines
1.6 KiB
C++
// Copyright (c) 2011-present, Facebook, Inc. All rights reserved.
|
|
// This source code is licensed under both the GPLv2 (found in the
|
|
// COPYING file in the root directory) and Apache 2.0 License
|
|
// (found in the LICENSE.Apache file in the root directory).
|
|
|
|
#include "rocksdb/write_buffer_manager.h"
|
|
|
|
#include <jni.h>
|
|
|
|
#include <cassert>
|
|
|
|
#include "include/org_rocksdb_WriteBufferManager.h"
|
|
#include "rocksdb/cache.h"
|
|
#include "rocksjni/cplusplus_to_java_convert.h"
|
|
|
|
/*
|
|
* Class: org_rocksdb_WriteBufferManager
|
|
* Method: newWriteBufferManager
|
|
* Signature: (JJ)J
|
|
*/
|
|
jlong Java_org_rocksdb_WriteBufferManager_newWriteBufferManager(
|
|
JNIEnv* /*env*/, jclass /*jclazz*/, jlong jbuffer_size, jlong jcache_handle,
|
|
jboolean allow_stall) {
|
|
auto* cache_ptr =
|
|
reinterpret_cast<std::shared_ptr<ROCKSDB_NAMESPACE::Cache>*>(
|
|
jcache_handle);
|
|
auto* write_buffer_manager =
|
|
new std::shared_ptr<ROCKSDB_NAMESPACE::WriteBufferManager>(
|
|
std::make_shared<ROCKSDB_NAMESPACE::WriteBufferManager>(
|
|
jbuffer_size, *cache_ptr, allow_stall));
|
|
return GET_CPLUSPLUS_POINTER(write_buffer_manager);
|
|
}
|
|
|
|
/*
|
|
* Class: org_rocksdb_WriteBufferManager
|
|
* Method: disposeInternal
|
|
* Signature: (J)V
|
|
*/
|
|
void Java_org_rocksdb_WriteBufferManager_disposeInternal(JNIEnv* /*env*/,
|
|
jobject /*jobj*/,
|
|
jlong jhandle) {
|
|
auto* write_buffer_manager =
|
|
reinterpret_cast<std::shared_ptr<ROCKSDB_NAMESPACE::WriteBufferManager>*>(
|
|
jhandle);
|
|
assert(write_buffer_manager != nullptr);
|
|
delete write_buffer_manager;
|
|
}
|