mirror of
https://github.com/facebook/rocksdb.git
synced 2024-12-02 10:15:54 +00:00
1cfdece85d
Summary: When internal cpp modernizer attempts to format rocksdb code, it will replace macro `ROCKSDB_NAMESPACE` with its default definition `rocksdb` when collapsing nested namespace. We filed a feedback for the tool T180254030 and the team filed a bug for this: https://github.com/llvm/llvm-project/issues/83452. At the same time, they suggested us to run the modernizer tool ourselves so future auto codemod attempts will be smaller. This diff contains: Running `xplat/scripts/codemod_service/cpp_modernizer.sh` in fbcode/internal_repo_rocksdb/repo (excluding some directories in utilities/transactions/lock/range/range_tree/lib that has a non meta copyright comment) without swapping out the namespace macro `ROCKSDB_NAMESPACE` Followed by RocksDB's own `make format` Pull Request resolved: https://github.com/facebook/rocksdb/pull/12398 Test Plan: Auto tests Reviewed By: hx235 Differential Revision: D54382532 Pulled By: jowlyzhang fbshipit-source-id: e7d5b40f9b113b60e5a503558c181f080b9d02fa
97 lines
3.3 KiB
C++
97 lines
3.3 KiB
C++
// Copyright (c) 2017-present, Facebook, Inc. All rights reserved.
|
|
// This source code is licensed under both the GPLv2 (found in the
|
|
// COPYING file in the root directory) and Apache 2.0 License
|
|
// (found in the LICENSE.Apache file in the root directory).
|
|
|
|
#include <memory>
|
|
|
|
#include "test_util/testharness.h"
|
|
#include "utilities/cassandra/format.h"
|
|
#include "utilities/cassandra/test_utils.h"
|
|
|
|
namespace ROCKSDB_NAMESPACE::cassandra {
|
|
|
|
class RowValueMergeTest : public testing::Test {};
|
|
|
|
TEST(RowValueMergeTest, Merge) {
|
|
std::vector<RowValue> row_values;
|
|
row_values.push_back(CreateTestRowValue({
|
|
CreateTestColumnSpec(kTombstone, 0, 5),
|
|
CreateTestColumnSpec(kColumn, 1, 8),
|
|
CreateTestColumnSpec(kExpiringColumn, 2, 5),
|
|
}));
|
|
|
|
row_values.push_back(CreateTestRowValue({
|
|
CreateTestColumnSpec(kColumn, 0, 2),
|
|
CreateTestColumnSpec(kExpiringColumn, 1, 5),
|
|
CreateTestColumnSpec(kTombstone, 2, 7),
|
|
CreateTestColumnSpec(kExpiringColumn, 7, 17),
|
|
}));
|
|
|
|
row_values.push_back(CreateTestRowValue({
|
|
CreateTestColumnSpec(kExpiringColumn, 0, 6),
|
|
CreateTestColumnSpec(kTombstone, 1, 5),
|
|
CreateTestColumnSpec(kColumn, 2, 4),
|
|
CreateTestColumnSpec(kTombstone, 11, 11),
|
|
}));
|
|
|
|
RowValue merged = RowValue::Merge(std::move(row_values));
|
|
EXPECT_FALSE(merged.IsTombstone());
|
|
EXPECT_EQ(merged.get_columns().size(), 5);
|
|
VerifyRowValueColumns(merged.get_columns(), 0, kExpiringColumn, 0, 6);
|
|
VerifyRowValueColumns(merged.get_columns(), 1, kColumn, 1, 8);
|
|
VerifyRowValueColumns(merged.get_columns(), 2, kTombstone, 2, 7);
|
|
VerifyRowValueColumns(merged.get_columns(), 3, kExpiringColumn, 7, 17);
|
|
VerifyRowValueColumns(merged.get_columns(), 4, kTombstone, 11, 11);
|
|
}
|
|
|
|
TEST(RowValueMergeTest, MergeWithRowTombstone) {
|
|
std::vector<RowValue> row_values;
|
|
|
|
// A row tombstone.
|
|
row_values.push_back(CreateRowTombstone(11));
|
|
|
|
// This row's timestamp is smaller than tombstone.
|
|
row_values.push_back(CreateTestRowValue({
|
|
CreateTestColumnSpec(kColumn, 0, 5),
|
|
CreateTestColumnSpec(kColumn, 1, 6),
|
|
}));
|
|
|
|
// Some of the column's row is smaller, some is larger.
|
|
row_values.push_back(CreateTestRowValue({
|
|
CreateTestColumnSpec(kColumn, 2, 10),
|
|
CreateTestColumnSpec(kColumn, 3, 12),
|
|
}));
|
|
|
|
// All of the column's rows are larger than tombstone.
|
|
row_values.push_back(CreateTestRowValue({
|
|
CreateTestColumnSpec(kColumn, 4, 13),
|
|
CreateTestColumnSpec(kColumn, 5, 14),
|
|
}));
|
|
|
|
RowValue merged = RowValue::Merge(std::move(row_values));
|
|
EXPECT_FALSE(merged.IsTombstone());
|
|
EXPECT_EQ(merged.get_columns().size(), 3);
|
|
VerifyRowValueColumns(merged.get_columns(), 0, kColumn, 3, 12);
|
|
VerifyRowValueColumns(merged.get_columns(), 1, kColumn, 4, 13);
|
|
VerifyRowValueColumns(merged.get_columns(), 2, kColumn, 5, 14);
|
|
|
|
// If the tombstone's timestamp is the latest, then it returns a
|
|
// row tombstone.
|
|
row_values.push_back(CreateRowTombstone(15));
|
|
|
|
row_values.push_back(CreateRowTombstone(17));
|
|
|
|
merged = RowValue::Merge(std::move(row_values));
|
|
EXPECT_TRUE(merged.IsTombstone());
|
|
EXPECT_EQ(merged.LastModifiedTime(), 17);
|
|
}
|
|
|
|
} // namespace ROCKSDB_NAMESPACE::cassandra
|
|
|
|
int main(int argc, char** argv) {
|
|
ROCKSDB_NAMESPACE::port::InstallStackTraceHandler();
|
|
::testing::InitGoogleTest(&argc, argv);
|
|
return RUN_ALL_TESTS();
|
|
}
|