mirror of
https://github.com/facebook/rocksdb.git
synced 2024-12-01 16:15:59 +00:00
9586dcf1ce
Summary: https://github.com/facebook/rocksdb/issues/9984 changes the behavior of RocksDB: if logger creation failed during `SanitizeOptions()`, `DB::Open()` will fail. However, since `SanitizeOptions()` is called in `DBImpl::DBImpl()`, we cannot directly expose the error to caller without some additional work. This is a first version proposal which: - Adds a new member `init_logger_creation_s` to `DBImpl` to store the result of init logger creation - Checks the error during `DB::Open()` and return it to caller if non-ok This is not very ideal. We can alternatively move the logger creation logic out of the `SanitizeOptions()`. Since `SanitizeOptions()` is used in other places, we need to check whether this change breaks anything in case other callers of `SanitizeOptions()` assumes that a logger should be created. Pull Request resolved: https://github.com/facebook/rocksdb/pull/10223 Test Plan: make check Reviewed By: pdillinger Differential Revision: D37321717 Pulled By: riversand963 fbshipit-source-id: 58042358a86369d606549dd9938933dd47591c4b |
||
|---|---|---|
| .. | ||
| agg_merge | ||
| backup | ||
| blob_db | ||
| cassandra | ||
| checkpoint | ||
| compaction_filters | ||
| convenience | ||
| leveldb_options | ||
| memory | ||
| merge_operators | ||
| option_change_migration | ||
| options | ||
| persistent_cache | ||
| simulator_cache | ||
| table_properties_collectors | ||
| trace | ||
| transactions | ||
| ttl | ||
| write_batch_with_index | ||
| cache_dump_load.cc | ||
| cache_dump_load_impl.cc | ||
| cache_dump_load_impl.h | ||
| compaction_filters.cc | ||
| counted_fs.cc | ||
| counted_fs.h | ||
| debug.cc | ||
| env_mirror.cc | ||
| env_mirror_test.cc | ||
| env_timed.cc | ||
| env_timed.h | ||
| env_timed_test.cc | ||
| fault_injection_env.cc | ||
| fault_injection_env.h | ||
| fault_injection_fs.cc | ||
| fault_injection_fs.h | ||
| fault_injection_secondary_cache.cc | ||
| fault_injection_secondary_cache.h | ||
| memory_allocators.h | ||
| merge_operators.cc | ||
| merge_operators.h | ||
| object_registry.cc | ||
| object_registry_test.cc | ||
| util_merge_operators_test.cc | ||
| wal_filter.cc | ||