rocksdb/test_util
anand76 98b0cbea88 Check iterator status BlockBasedTableReader::VerifyChecksumInBlocks() (#6909)
Summary:
The ```for``` loop in ```VerifyChecksumInBlocks``` only checks ```index_iter->Valid()``` which could be ```false``` either due to reaching the end of the index or, in case of partitioned index, it could be due to a checksum mismatch error when reading a 2nd level index block. Instead of throwing away the index iterator status, we need to return any errors back to the caller.

Tests:
Add a test in block_based_table_reader_test.cc.
Pull Request resolved: https://github.com/facebook/rocksdb/pull/6909

Reviewed By: pdillinger

Differential Revision: D21833922

Pulled By: anand1976

fbshipit-source-id: bc778ebf1121dbbdd768689de5183f07a9f0beae
2020-06-05 11:08:25 -07:00
..
fault_injection_test_env.cc Suppress file deletion error message in FaultInjectionTestEnv (#6696) 2020-04-14 10:55:10 -07:00
fault_injection_test_env.h Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433) 2020-02-20 12:09:57 -08:00
fault_injection_test_fs.cc Fix a couple of bugs in FaultInjectionTestFS (#6777) 2020-04-29 19:28:29 -07:00
fault_injection_test_fs.h Fix a couple of bugs in FaultInjectionTestFS (#6777) 2020-04-29 19:28:29 -07:00
mock_time_env.h Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433) 2020-02-20 12:09:57 -08:00
sync_point.cc Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433) 2020-02-20 12:09:57 -08:00
sync_point.h Reduce dependency on gtest dependency in release code (#6907) 2020-06-02 12:11:24 -07:00
sync_point_impl.cc Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433) 2020-02-20 12:09:57 -08:00
sync_point_impl.h Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433) 2020-02-20 12:09:57 -08:00
testharness.cc Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433) 2020-02-20 12:09:57 -08:00
testharness.h Reduce dependency on gtest dependency in release code (#6907) 2020-06-02 12:11:24 -07:00
testutil.cc Check iterator status BlockBasedTableReader::VerifyChecksumInBlocks() (#6909) 2020-06-05 11:08:25 -07:00
testutil.h Check iterator status BlockBasedTableReader::VerifyChecksumInBlocks() (#6909) 2020-06-05 11:08:25 -07:00
testutil_test.cc Make DestroyDir destroy directories recursively (#6934) 2020-06-05 10:55:22 -07:00
transaction_test_util.cc C++20 compatibility (#6697) 2020-04-20 13:24:25 -07:00
transaction_test_util.h Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433) 2020-02-20 12:09:57 -08:00