mirror of
https://github.com/facebook/rocksdb.git
synced 2024-11-26 16:30:56 +00:00
bda8d93ba9
Summary: It's always annoying to find a header does not include its own dependencies and only works when included after other includes. This change adds `make check-headers` which validates that each header can be included at the top of a file. Some headers are excluded e.g. because of platform or external dependencies. rocksdb_namespace.h had to be re-worked slightly to enable checking for failure to include it. (ROCKSDB_NAMESPACE is a valid namespace name.) Fixes mostly involve adding and cleaning up #includes, but for FileTraceWriter, a constructor was out-of-lined to make a forward declaration sufficient. This check is not currently run with `make check` but is added to CircleCI build-linux-unity since that one is already relatively fast. Pull Request resolved: https://github.com/facebook/rocksdb/pull/8893 Test Plan: existing tests and resolving issues detected by new check Reviewed By: mrambacher Differential Revision: D30823300 Pulled By: pdillinger fbshipit-source-id: 9fff223944994c83c105e2e6496d24845dc8e572
66 lines
2.1 KiB
C++
66 lines
2.1 KiB
C++
// Copyright (c) 2011-present, Facebook, Inc. All rights reserved.
|
|
// This source code is licensed under both the GPLv2 (found in the
|
|
// COPYING file in the root directory) and Apache 2.0 License
|
|
// (found in the LICENSE.Apache file in the root directory).
|
|
|
|
#pragma once
|
|
|
|
#include "rocksdb/table.h"
|
|
#include "util/gflags_compat.h"
|
|
#include "util/random.h"
|
|
|
|
DECLARE_int32(mark_for_compaction_one_file_in);
|
|
|
|
namespace ROCKSDB_NAMESPACE {
|
|
|
|
// A `DbStressTablePropertiesCollector` ignores what keys/values were added to
|
|
// the table, adds no properties to the table, and decides at random whether the
|
|
// table will be marked for compaction according to
|
|
// `FLAGS_mark_for_compaction_one_file_in`.
|
|
class DbStressTablePropertiesCollector : public TablePropertiesCollector {
|
|
public:
|
|
DbStressTablePropertiesCollector()
|
|
: need_compact_(Random::GetTLSInstance()->OneInOpt(
|
|
FLAGS_mark_for_compaction_one_file_in)) {}
|
|
|
|
virtual Status AddUserKey(const Slice& /* key */, const Slice& /* value */,
|
|
EntryType /*type*/, SequenceNumber /*seq*/,
|
|
uint64_t /*file_size*/) override {
|
|
return Status::OK();
|
|
}
|
|
|
|
virtual Status Finish(UserCollectedProperties* /* properties */) override {
|
|
return Status::OK();
|
|
}
|
|
|
|
virtual UserCollectedProperties GetReadableProperties() const override {
|
|
return UserCollectedProperties{};
|
|
}
|
|
|
|
virtual const char* Name() const override {
|
|
return "DbStressTablePropertiesCollector";
|
|
}
|
|
|
|
virtual bool NeedCompact() const override { return need_compact_; }
|
|
|
|
private:
|
|
const bool need_compact_;
|
|
};
|
|
|
|
// A `DbStressTablePropertiesCollectorFactory` creates
|
|
// `DbStressTablePropertiesCollectorFactory`s.
|
|
class DbStressTablePropertiesCollectorFactory
|
|
: public TablePropertiesCollectorFactory {
|
|
public:
|
|
virtual TablePropertiesCollector* CreateTablePropertiesCollector(
|
|
TablePropertiesCollectorFactory::Context /* context */) override {
|
|
return new DbStressTablePropertiesCollector();
|
|
}
|
|
|
|
virtual const char* Name() const override {
|
|
return "DbStressTablePropertiesCollectorFactory";
|
|
}
|
|
};
|
|
|
|
} // namespace ROCKSDB_NAMESPACE
|