mirror of
https://github.com/facebook/rocksdb.git
synced 2024-11-29 18:33:58 +00:00
62247ffa3b
Summary: When using latest clang (3.6 or 3.7/trunck) rocksdb is failing with many errors. Almost all of them are missing override errors. This diff adds missing override keyword. No manual changes. Prerequisites: bear and clang 3.5 build with extra tools ```lang=bash % USE_CLANG=1 bear make all # generate a compilation database http://clang.llvm.org/docs/JSONCompilationDatabase.html % clang-modernize -p . -include . -add-override % make format ``` Test Plan: Make sure all tests are passing. ```lang=bash % #Use default fb code clang. % make check ``` Verify less error and no missing override errors. ```lang=bash % # Have trunk clang present in path. % ROCKSDB_NO_FBCODE=1 CC=clang CXX=clang++ make ``` Reviewers: igor, kradhakrishnan, rven, meyering, sdong Reviewed By: sdong Subscribers: dhruba, leveldb Differential Revision: https://reviews.facebook.net/D34077
100 lines
3.5 KiB
C++
100 lines
3.5 KiB
C++
// Copyright (c) 2014, Facebook, Inc. All rights reserved.
|
|
// This source code is licensed under the BSD-style license found in the
|
|
// LICENSE file in the root directory of this source tree. An additional grant
|
|
// of patent rights can be found in the PATENTS file in the same directory.
|
|
//
|
|
// Copyright (c) 2011 The LevelDB Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file. See the AUTHORS file for names of contributors.
|
|
#pragma once
|
|
|
|
#include <atomic>
|
|
#include <map>
|
|
#include <string>
|
|
#include <vector>
|
|
#include "rocksdb/env.h"
|
|
#include "rocksdb/status.h"
|
|
#include "port/port.h"
|
|
#include "util/mutexlock.h"
|
|
|
|
namespace rocksdb {
|
|
|
|
class MemFile;
|
|
class MockEnv : public EnvWrapper {
|
|
public:
|
|
explicit MockEnv(Env* base_env);
|
|
|
|
virtual ~MockEnv();
|
|
|
|
// Partial implementation of the Env interface.
|
|
virtual Status NewSequentialFile(const std::string& fname,
|
|
unique_ptr<SequentialFile>* result,
|
|
const EnvOptions& soptions) override;
|
|
|
|
virtual Status NewRandomAccessFile(const std::string& fname,
|
|
unique_ptr<RandomAccessFile>* result,
|
|
const EnvOptions& soptions) override;
|
|
|
|
virtual Status NewWritableFile(const std::string& fname,
|
|
unique_ptr<WritableFile>* result,
|
|
const EnvOptions& env_options) override;
|
|
|
|
virtual Status NewRandomRWFile(const std::string& fname,
|
|
unique_ptr<RandomRWFile>* result,
|
|
const EnvOptions& options) override;
|
|
|
|
virtual Status NewDirectory(const std::string& name,
|
|
unique_ptr<Directory>* result) override;
|
|
|
|
virtual bool FileExists(const std::string& fname) override;
|
|
|
|
virtual Status GetChildren(const std::string& dir,
|
|
std::vector<std::string>* result) override;
|
|
|
|
void DeleteFileInternal(const std::string& fname);
|
|
|
|
virtual Status DeleteFile(const std::string& fname) override;
|
|
|
|
virtual Status CreateDir(const std::string& dirname) override;
|
|
|
|
virtual Status CreateDirIfMissing(const std::string& dirname) override;
|
|
|
|
virtual Status DeleteDir(const std::string& dirname) override;
|
|
|
|
virtual Status GetFileSize(const std::string& fname,
|
|
uint64_t* file_size) override;
|
|
|
|
virtual Status GetFileModificationTime(const std::string& fname,
|
|
uint64_t* time) override;
|
|
|
|
virtual Status RenameFile(const std::string& src,
|
|
const std::string& target) override;
|
|
|
|
virtual Status LinkFile(const std::string& src,
|
|
const std::string& target) override;
|
|
|
|
virtual Status NewLogger(const std::string& fname,
|
|
shared_ptr<Logger>* result) override;
|
|
|
|
virtual Status LockFile(const std::string& fname, FileLock** flock) override;
|
|
|
|
virtual Status UnlockFile(FileLock* flock) override;
|
|
|
|
virtual Status GetTestDirectory(std::string* path) override;
|
|
|
|
// Non-virtual functions, specific to MockEnv
|
|
Status Truncate(const std::string& fname, size_t size);
|
|
|
|
Status CorruptBuffer(const std::string& fname);
|
|
|
|
private:
|
|
std::string NormalizePath(const std::string path);
|
|
|
|
// Map from filenames to MemFile objects, representing a simple file system.
|
|
typedef std::map<std::string, MemFile*> FileSystem;
|
|
port::Mutex mutex_;
|
|
FileSystem file_map_; // Protected by mutex_.
|
|
};
|
|
|
|
} // namespace rocksdb
|